Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

Issue 2544883006: Cleanup: Replace NTPLoggingTileSource by ntp_tiles::NTPTileSource (Closed)
Patch Set: tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
index 6e43620b6e83baed9c80b1b3f45521f31f25a697..fcb0b593c80105251cb016d131d78c7d92d403a8 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
@@ -40,17 +40,6 @@ void RecordSyncSessionMetrics(content::WebContents* contents) {
sessions);
}
-ntp_tiles::NTPTileSource ConvertTileSource(NTPLoggingTileSource tile_source) {
- switch (tile_source) {
- case NTPLoggingTileSource::CLIENT:
- return ntp_tiles::NTPTileSource::TOP_SITES;
- case NTPLoggingTileSource::SERVER:
- return ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE;
- }
- NOTREACHED();
- return ntp_tiles::NTPTileSource::TOP_SITES;
-}
-
} // namespace
DEFINE_WEB_CONTENTS_USER_DATA_KEY(NTPUserDataLogger);
@@ -109,7 +98,8 @@ void NTPUserDataLogger::LogEvent(NTPLoggingEventType event,
}
void NTPUserDataLogger::LogMostVisitedImpression(
- int position, NTPLoggingTileSource tile_source) {
+ int position,
+ ntp_tiles::NTPTileSource tile_source) {
if ((position >= kNumMostVisited) || impression_was_logged_[position]) {
return;
}
@@ -118,8 +108,9 @@ void NTPUserDataLogger::LogMostVisitedImpression(
}
void NTPUserDataLogger::LogMostVisitedNavigation(
- int position, NTPLoggingTileSource tile_source) {
- ntp_tiles::metrics::RecordTileClick(position, ConvertTileSource(tile_source),
+ int position,
+ ntp_tiles::NTPTileSource tile_source) {
+ ntp_tiles::metrics::RecordTileClick(position, tile_source,
ntp_tiles::metrics::THUMBNAIL);
// Records the action. This will be available as a time-stamped stream
@@ -172,10 +163,11 @@ void NTPUserDataLogger::EmitNtpStatistics(base::TimeDelta load_time) {
if (!impression_was_logged_[i]) {
break;
}
- if (impression_tile_source_[i] == NTPLoggingTileSource::SERVER) {
+ if (impression_tile_source_[i] ==
+ ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE) {
has_server_side_suggestions = true;
}
- tiles.emplace_back(ConvertTileSource(impression_tile_source_[i]),
+ tiles.emplace_back(impression_tile_source_[i],
ntp_tiles::metrics::THUMBNAIL);
}
ntp_tiles::metrics::RecordPageImpression(tiles);
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.h ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698