Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2544813002: Remove enum SpdyMajorVersion. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enum SpdyMajorVersion. This CL lands server changes 140349928 by alyssar and 140661724 by bnc. BUG=624095, 488484 Committed: https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd Cr-Commit-Position: refs/heads/master@{#435661}

Patch Set 1 #

Patch Set 2 : Revert creating local variables to avoid silly compiler error about int to bool conversion. #

Total comments: 1

Patch Set 3 : Merge comment changes from 140661724. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -661 lines) Patch
M net/quic/core/quic_headers_stream.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/spdy_utils.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_deframer_visitor_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_frame_builder.h View 5 chunks +6 lines, -13 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 4 chunks +6 lines, -14 lines 0 comments Download
M net/spdy/spdy_frame_builder_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_framer.h View 6 chunks +11 lines, -23 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 55 chunks +122 lines, -212 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 128 chunks +174 lines, -181 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.h View 3 chunks +1 line, -6 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 5 chunks +41 lines, -79 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 12 chunks +31 lines, -74 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 1 chunk +2 lines, -6 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Bence
Ryan: PTAL. Thank you. https://codereview.chromium.org/2544813002/diff/20001/net/quic/core/quic_headers_stream.cc File net/quic/core/quic_headers_stream.cc (right): https://codereview.chromium.org/2544813002/diff/20001/net/quic/core/quic_headers_stream.cc#newcode301 net/quic/core/quic_headers_stream.cc:301: void CloseConnection(const string& details) { ...
4 years ago (2016-12-01 18:32:09 UTC) #15
Ryan Hamilton
lgtm
4 years ago (2016-12-01 18:46:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544813002/40001
4 years ago (2016-12-01 18:46:41 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 18:51:51 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-01 18:54:14 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9921fa1d778e80abd7239e39457c4456122a7bdd
Cr-Commit-Position: refs/heads/master@{#435661}

Powered by Google App Engine
This is Rietveld 408576698