Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: net/spdy/spdy_headers_block_parser_test.cc

Issue 2544813002: Remove enum SpdyMajorVersion. (Closed)
Patch Set: Merge comment changes from 140661724. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_headers_block_parser.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_headers_block_parser_test.cc
diff --git a/net/spdy/spdy_headers_block_parser_test.cc b/net/spdy/spdy_headers_block_parser_test.cc
index 44d8e7a1f95f96f5c9bcec529cc5da99359b62ca..00f8fc43fa5a6a58ea1e8c7c6dee920bb9c3f4dd 100644
--- a/net/spdy/spdy_headers_block_parser_test.cc
+++ b/net/spdy/spdy_headers_block_parser_test.cc
@@ -35,15 +35,14 @@ class MockSpdyHeadersHandler : public SpdyHeadersHandlerInterface {
MOCK_METHOD2(OnHeader, void(StringPiece key, StringPiece value));
};
-class SpdyHeadersBlockParserTest :
- public ::testing::TestWithParam<SpdyMajorVersion> {
+class SpdyHeadersBlockParserTest : public ::testing::Test {
public:
~SpdyHeadersBlockParserTest() override {}
protected:
void SetUp() override {
// Create a parser using the mock handler.
- parser_.reset(new SpdyHeadersBlockParser(HTTP2, &handler_));
+ parser_.reset(new SpdyHeadersBlockParser(&handler_));
}
// Create a header block with a specified number of headers.
@@ -225,7 +224,7 @@ TEST_F(SpdyHeadersBlockParserTest, LargeBlocksDiscardedTest) {
EXPECT_EQ(SpdyHeadersBlockParser::HEADER_BLOCK_TOO_LARGE,
parser_->get_error());
}
- parser_.reset(new SpdyHeadersBlockParser(HTTP2, &handler_));
+ parser_.reset(new SpdyHeadersBlockParser(&handler_));
// Header block with one header, which has a too-long key.
{
string headers = EncodeLength(1) + EncodeLength(
« no previous file with comments | « net/spdy/spdy_headers_block_parser.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698