Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: net/spdy/spdy_frame_builder_test.cc

Issue 2544813002: Remove enum SpdyMajorVersion. (Closed)
Patch Set: Merge comment changes from 140661724. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_frame_builder_test.cc
diff --git a/net/spdy/spdy_frame_builder_test.cc b/net/spdy/spdy_frame_builder_test.cc
index 158c0a5ebb77c11fe993970e9d9d26ee48eedb64..921df69847725a16ef82738a16b3e15b23980a43 100644
--- a/net/spdy/spdy_frame_builder_test.cc
+++ b/net/spdy/spdy_frame_builder_test.cc
@@ -12,7 +12,7 @@ namespace net {
TEST(SpdyFrameBuilderTest, GetWritableBuffer) {
const size_t kBuilderSize = 10;
- SpdyFrameBuilder builder(kBuilderSize, HTTP2);
+ SpdyFrameBuilder builder(kBuilderSize);
char* writable_buffer = builder.GetWritableBuffer(kBuilderSize);
memset(writable_buffer, ~1, kBuilderSize);
EXPECT_TRUE(builder.Seek(kBuilderSize));
@@ -27,10 +27,10 @@ TEST(SpdyFrameBuilderTest, RewriteLength) {
// Create an empty SETTINGS frame both via framer and manually via builder.
// The one created via builder is initially given the incorrect length, but
// then is corrected via RewriteLength().
- SpdyFramer framer(HTTP2);
+ SpdyFramer framer;
SpdySettingsIR settings_ir;
SpdySerializedFrame expected(framer.SerializeSettings(settings_ir));
- SpdyFrameBuilder builder(expected.size() + 1, HTTP2);
+ SpdyFrameBuilder builder(expected.size() + 1);
builder.BeginNewFrame(framer, SETTINGS, 0, 0);
EXPECT_TRUE(builder.GetWritableBuffer(1) != NULL);
builder.RewriteLength(framer);
@@ -42,10 +42,10 @@ TEST(SpdyFrameBuilderTest, RewriteLength) {
TEST(SpdyFrameBuilderTest, OverwriteFlags) {
// Create a HEADERS frame both via framer and manually via builder with
// different flags set, then make them match using OverwriteFlags().
- SpdyFramer framer(HTTP2);
+ SpdyFramer framer;
SpdyHeadersIR headers_ir(1);
SpdySerializedFrame expected(framer.SerializeHeaders(headers_ir));
- SpdyFrameBuilder builder(expected.size(), HTTP2);
+ SpdyFrameBuilder builder(expected.size());
builder.BeginNewFrame(framer, HEADERS, 0, 1);
builder.OverwriteFlags(framer, HEADERS_FLAG_END_HEADERS);
SpdySerializedFrame built(builder.take());
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698