Disable AVX2 for Skia in the SyzyAsan build of Chrome.

Disable AVX2 for Skia in the SyzyAsan build of Chrome.

The Syzygy instrumentation pipeline doesn't support AVX2.

R=mtklein@chromium.org
CC=syzygy-team@chromium.org

BUG=670664
Committed: https://crrev.com/47f73d2d11ba660b3de16705f70911faf9956bb3
Cr-Commit-Position: refs/heads/master@{#435727}

[Sébastien Marchand, 2016-12-01 20:40:04]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 20:40:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2016-12-01 20:48:46]

PTAL.

https://codereview.chromium.org/2544503004/diff/1/skia/ext/SkOpts_hsw_stub.cc
File skia/ext/SkOpts_hsw_stub.cc (right):

https://codereview.chromium.org/2544503004/diff/1/skia/ext/SkOpts_hsw_stub.cc...
skia/ext/SkOpts_hsw_stub.cc:10: void Init_hsw();
indentation is weird (to me) and it's weird to have the declaration and the
implementation separated (and no include guard), but it's how this file was
written before its removal in https://codereview.chromium.org/2539453003/

[mtklein_C, 2016-12-01 20:54:18]

lgtm

https://codereview.chromium.org/2544503004/diff/1/skia/ext/SkOpts_hsw_stub.cc
File skia/ext/SkOpts_hsw_stub.cc (right):

https://codereview.chromium.org/2544503004/diff/1/skia/ext/SkOpts_hsw_stub.cc...
skia/ext/SkOpts_hsw_stub.cc:10: void Init_hsw();
On 2016/12/01 at 20:48:46, Sébastien Marchand wrote:
> indentation is weird (to me) and it's weird to have the declaration and the
implementation separated (and no include guard), but it's how this file was
written before its removal in https://codereview.chromium.org/2539453003/

These SkOpts::Init_foo() methods are not actually declared in any header, though
they are declared where referenced in SkOpts.cpp.
I think when I wrote this I just wanted to make it clear that this is an extern
function.

This being a .cpp file, I'm not sure why we'd need an include guard or where
we'd put it?

[Sébastien Marchand, 2016-12-01 21:02:42]

Oops, overlooked the fact that this is a cpp file and not a header :)

[commit-bot: I haz the power, 2016-12-01 21:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:39:31]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2016-12-01 21:40:19]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:45:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480628419308350, "parent_rev":
"ca3a1894a28423ae6f7878deee131fe19b3cc550", "commit_rev":
"190414a5f3ea896fc05864ef7d5e45d7deed9912"}

[commit-bot: I haz the power, 2016-12-01 21:45:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 21:48:59]

Description was changed from

==========
Disable AVX2 for Skia in the SyzyAsan build of Chrome.

The Syzygy instrumentation pipeline doesn't support AVX2.

R=mtklein@chromium.org
CC=syzygy-team@chromium.org
==========

to

==========
Disable AVX2 for Skia in the SyzyAsan build of Chrome.

The Syzygy instrumentation pipeline doesn't support AVX2.

R=mtklein@chromium.org
CC=syzygy-team@chromium.org

Committed: https://crrev.com/47f73d2d11ba660b3de16705f70911faf9956bb3
Cr-Commit-Position: refs/heads/master@{#435727}
==========

[commit-bot: I haz the power, 2016-12-01 21:49:00]

Patchset 1 (id:??) landed as
https://crrev.com/47f73d2d11ba660b3de16705f70911faf9956bb3
Cr-Commit-Position: refs/heads/master@{#435727}

[Sébastien Marchand, 2016-12-02 13:39:40]

Description was changed from

==========
Disable AVX2 for Skia in the SyzyAsan build of Chrome.

The Syzygy instrumentation pipeline doesn't support AVX2.

R=mtklein@chromium.org
CC=syzygy-team@chromium.org

Committed: https://crrev.com/47f73d2d11ba660b3de16705f70911faf9956bb3
Cr-Commit-Position: refs/heads/master@{#435727}
==========

to

==========
Disable AVX2 for Skia in the SyzyAsan build of Chrome.

The Syzygy instrumentation pipeline doesn't support AVX2.

R=mtklein@chromium.org
CC=syzygy-team@chromium.org

BUG=670664

Committed: https://crrev.com/47f73d2d11ba660b3de16705f70911faf9956bb3
Cr-Commit-Position: refs/heads/master@{#435727}
==========