Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2539453003: Revert of Stub out Skia AVX and HSW opts. (Closed)

Created:
4 years ago by mtklein_C
Modified:
4 years ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stub out Skia AVX and HSW opts. (patchset #1 id:1 of https://codereview.chromium.org/2512093003/ ) Reason for revert: Now that we're guarding against ucrt\math.h in Skia and that's rolled into Chromium, it's as good a time as ever to try turning back on Skia's AVX+ code at head. (I intend to just leave it stubbed out like this in M56.) Original issue's description: > Stub out Skia AVX and HSW opts. > > This is hopefully temporary while we mull better options. > > BUG=666707 > > Committed: https://crrev.com/2ea76e2274404af7e53cc4bb5d212b22856ee455 > Cr-Commit-Position: refs/heads/master@{#433407} TBR=brucedawson@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=666707 Committed: https://crrev.com/0dcd8a3ef5f7cdcdd556aeeed1db09e86c3e5ae5 Cr-Commit-Position: refs/heads/master@{#434983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M skia/BUILD.gn View 2 chunks +2 lines, -10 lines 0 comments Download
D skia/ext/SkOpts_avx_stub.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D skia/ext/SkOpts_hsw_stub.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
Created Revert of Stub out Skia AVX and HSW opts.
4 years ago (2016-11-29 13:27:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539453003/1
4 years ago (2016-11-29 13:27:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 14:24:54 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-29 14:27:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dcd8a3ef5f7cdcdd556aeeed1db09e86c3e5ae5
Cr-Commit-Position: refs/heads/master@{#434983}

Powered by Google App Engine
This is Rietveld 408576698