Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: skia/BUILD.gn

Issue 2544503004: Disable AVX2 for Skia in the SyzyAsan build of Chrome. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/ext/SkOpts_hsw_stub.cc » ('j') | skia/ext/SkOpts_hsw_stub.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index d0855c9430afe8de5ac33dbaf67ff97406e5b5a4..b239fa059185ccde858e58031906a53943b44efa 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
+import("//build/config/sanitizers/sanitizers.gni")
import("//printing/features/features.gni")
import("//testing/test.gni")
import("//third_party/skia/gn/shared_sources.gni")
@@ -564,7 +565,14 @@ if (!skia_build_no_opts) {
]
}
source_set("skia_opts_hsw") {
- sources = skia_opts.hsw_sources
+ # SyzyAsan doesn't support the AVX2 and F16C instructions.
+ if (!is_syzyasan) {
+ sources = skia_opts.hsw_sources
+ } else {
+ sources = [
+ "ext/SkOpts_hsw_stub.cc",
+ ]
+ }
if (!is_win) {
cflags = [
"-mavx2",
@@ -574,7 +582,7 @@ if (!skia_build_no_opts) {
"-mfma",
]
}
- if (is_win) {
+ if (is_win && !is_syzyasan) {
cflags = [ "/arch:AVX2" ]
}
visibility = [ ":skia_opts" ]
« no previous file with comments | « no previous file | skia/ext/SkOpts_hsw_stub.cc » ('j') | skia/ext/SkOpts_hsw_stub.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698