Delete old RenderPassId mappings in SurfaceAggregator.

Delete old RenderPassId mappings in SurfaceAggregator.

Mappings need to stay the same across frames so textures aren't
unnecessarily reallocated, but they should be deleted once they're not
used to avoid leaking memory.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/8280e63a215468a2f75f96b7a052ad1316912638
Cr-Commit-Position: refs/heads/master@{#436134}

[jbauman, 2016-12-02 03:37:11]

Description was changed from

==========
Delete old RenderPassId mappings in SurfaceAggregator.

Mappings need to stay the same across frames so textures aren't
unnecessarily reallocated, but they should be deleted once they're not
used to avoid leaking memory.
==========

to

==========
Delete old RenderPassId mappings in SurfaceAggregator.

Mappings need to stay the same across frames so textures aren't
unnecessarily reallocated, but they should be deleted once they're not
used to avoid leaking memory.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbauman, 2016-12-02 03:37:17]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 03:37:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-12-02 03:55:27]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 03:55:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 05:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 05:30:21]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-12-02 10:14:12]

jbauman@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-12-02 21:55:16]

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.h (right):

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.h:67: RenderPassId id;
This can use some comments. The key already has an id but this is a different id
so what is it and what is the key?

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.h:119: std::map<std::pair<SurfaceId,
RenderPassId>, RenderPassInfo>;
Same.. comments pls

[danakj, 2016-12-02 22:17:53]

LGTM w/ a couple comments on the test

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator_unittest.cc (right):

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_unittest.cc:280: EXPECT_EQ(RenderPassId(1, 2),
aggregated_frame.render_pass_list[0]->id);
instead of hardcoding the result can u just store them here then compare after,
which is what u intend from the comment?

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_unittest.cc:297: EXPECT_EQ(RenderPassId(1, 3),
aggregated_frame.render_pass_list[0]->id);
and then check this is a new thing with NE compares

https://codereview.chromium.org/2544203003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator_unittest.cc:306: EXPECT_EQ(RenderPassId(1, 4),
aggregated_frame.render_pass_list[0]->id);
same same?

[jbauman, 2016-12-03 00:38:33]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-12-03 00:38:33]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2544203003/#ps40001
(title: "change test checks, add comments")

[commit-bot: I haz the power, 2016-12-03 00:39:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-12-03 00:39:52]

Thanks, great comments.

[commit-bot: I haz the power, 2016-12-03 01:40:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480725513214290,
"parent_rev": "73b252333ba3d51f87a4f61f21060dca275ed72c", "commit_rev":
"d398b87d8ee431d991dc1d34ba95b36fd5d35707"}

[commit-bot: I haz the power, 2016-12-03 01:41:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-03 01:44:58]

Description was changed from

==========
Delete old RenderPassId mappings in SurfaceAggregator.

Mappings need to stay the same across frames so textures aren't
unnecessarily reallocated, but they should be deleted once they're not
used to avoid leaking memory.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Delete old RenderPassId mappings in SurfaceAggregator.

Mappings need to stay the same across frames so textures aren't
unnecessarily reallocated, but they should be deleted once they're not
used to avoid leaking memory.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/8280e63a215468a2f75f96b7a052ad1316912638
Cr-Commit-Position: refs/heads/master@{#436134}
==========

[commit-bot: I haz the power, 2016-12-03 01:44:59]

Patchset 3 (id:??) landed as
https://crrev.com/8280e63a215468a2f75f96b7a052ad1316912638
Cr-Commit-Position: refs/heads/master@{#436134}