Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 2543373002: Extract non-Mojo bits of GpuCompositorFrameSink to CompositorFrameSinkSupport (Closed)

Created:
4 years ago by Fady Samuel
Modified:
4 years ago
Reviewers:
piman
CC:
chromium-reviews, rjkroege, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract non-Mojo bits of GpuCompositorFrameSink to CompositorFrameSinkSupport We would like to have all Chrome clients use a single service-side CompositorFrameSink implementation as an incremental step towards pulling the display compositor into the gpu process. This CL extract non-mojo-specific code from GpuCompositorFrameSink in services/ui to CompositorFrameSinkSupport in a central place: cc/surfaces that can be used by Chrome today. Individual clients can transition to mojo after we carefully measure the performance impact of the transition. BUG=668126, 657959 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/932aa65ca04713744f3166c973c19560c1faa75f Cr-Commit-Position: refs/heads/master@{#436148}

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 6

Patch Set 3 : Addressed Antoine's comments #

Patch Set 4 : NON_EXPORTED_BASE(DisplayClient) #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -188 lines) Patch
M cc/surfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A cc/surfaces/compositor_frame_sink_support.h View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
A cc/surfaces/compositor_frame_sink_support.cc View 1 2 3 4 1 chunk +173 lines, -0 lines 0 comments Download
A cc/surfaces/compositor_frame_sink_support_client.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M services/ui/surfaces/gpu_compositor_frame_sink.h View 1 2 3 4 4 chunks +13 lines, -63 lines 0 comments Download
M services/ui/surfaces/gpu_compositor_frame_sink.cc View 1 2 3 4 3 chunks +23 lines, -125 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Fady Samuel
4 years ago (2016-12-02 21:46:35 UTC) #4
piman
LGTM with a couple of nits/comments https://codereview.chromium.org/2543373002/diff/20001/cc/surfaces/compositor_frame_sink_support.cc File cc/surfaces/compositor_frame_sink_support.cc (right): https://codereview.chromium.org/2543373002/diff/20001/cc/surfaces/compositor_frame_sink_support.cc#newcode58 cc/surfaces/compositor_frame_sink_support.cc:58: display_->Resize(frame_size); This is ...
4 years ago (2016-12-02 22:44:30 UTC) #6
Fady Samuel
Thanks Antoine! CQ'ing! https://codereview.chromium.org/2543373002/diff/20001/cc/surfaces/compositor_frame_sink_support.cc File cc/surfaces/compositor_frame_sink_support.cc (right): https://codereview.chromium.org/2543373002/diff/20001/cc/surfaces/compositor_frame_sink_support.cc#newcode58 cc/surfaces/compositor_frame_sink_support.cc:58: display_->Resize(frame_size); On 2016/12/02 22:44:29, piman wrote: ...
4 years ago (2016-12-02 23:05:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543373002/40001
4 years ago (2016-12-02 23:05:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/307973)
4 years ago (2016-12-03 00:33:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543373002/60001
4 years ago (2016-12-03 01:15:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543373002/80001
4 years ago (2016-12-03 01:45:06 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-03 02:39:19 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-03 02:41:35 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/932aa65ca04713744f3166c973c19560c1faa75f
Cr-Commit-Position: refs/heads/master@{#436148}

Powered by Google App Engine
This is Rietveld 408576698