Move Smi::kZero definition to the header

Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=v8:5684
Committed: https://crrev.com/34342f312c39374068fbe82e42ca2579e7077710
Cr-Commit-Position: refs/heads/master@{#41450}

[Clemens Hammacher, 2016-11-29 14:58:21]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 14:58:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-29 14:59:42]

Description was changed from

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

R=ishell@chromium.org
CC=jgruber@chromium.org
==========

to

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
==========

[Clemens Hammacher, 2016-11-29 15:01:11]

The CQ bit was unchecked by clemensh@chromium.org

[Clemens Hammacher, 2016-11-29 15:01:22]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 15:01:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 15:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:05:12]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[Clemens Hammacher, 2016-11-29 15:21:26]

Description was changed from

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
==========

to

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=5684
==========

[Igor Sheludko, 2016-11-29 15:28:56]

lgtm once we switch to MSVC2015.

[Clemens Hammacher, 2016-12-02 09:37:08]

Description was changed from

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=5684
==========

to

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=v8:5684
==========

[Clemens Hammacher, 2016-12-02 09:37:46]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:05:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480671466901700,
"parent_rev": "59553f78b386d965c3b5512d26881f85e9a5055e", "commit_rev":
"0b8adaaadfe7e3a8e7d2c23284a918e81bcbcacd"}

[commit-bot: I haz the power, 2016-12-02 10:05:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 10:06:03]

Description was changed from

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=v8:5684
==========

to

==========
Move Smi::kZero definition to the header

Since we don't pass references to this constant to the DCHECKs any more
(see http://crrev.com/2524093002), the constant can now be initialized
in the header, reducing code size and increasing performance.

Before the mentioned change in CHECK/DCHECK, this caused link errors.

R=ishell@chromium.org
CC=jgruber@chromium.org
BUG=v8:5684

Committed: https://crrev.com/34342f312c39374068fbe82e42ca2579e7077710
Cr-Commit-Position: refs/heads/master@{#41450}
==========

[commit-bot: I haz the power, 2016-12-02 10:06:04]

Patchset 2 (id:??) landed as
https://crrev.com/34342f312c39374068fbe82e42ca2579e7077710
Cr-Commit-Position: refs/heads/master@{#41450}

[jgruber, 2016-12-02 10:08:36]

On 2016/12/02 10:06:04, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/34342f312c39374068fbe82e42ca2579e7077710
> Cr-Commit-Position: refs/heads/master@{#41450}

Very nice!