src/objects.cc - Issue 2541533002: Move Smi::kZero definition to the header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2541533002: Move Smi::kZero definition to the header (Closed)

Patch Set: Change "constexpr static" to "static constexpr" for consistency Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 6d8a1be02a83e228eca6134f24d41a99e25ab54d..80a3b283af6f9e900fd949f6dfe52bb53476c92a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -2203,9 +2203,6 @@ std::ostream& operator<<(std::ostream& os, const Brief& v) {

return os;

}

-// Declaration of the static Smi::kZero constant.

-Smi* const Smi::kZero(nullptr);

void Smi::SmiPrint(std::ostream& os) const { // NOLINT

os << value();

}

« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »