src/objects.h - Issue 2541533002: Move Smi::kZero definition to the header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 2541533002: Move Smi::kZero definition to the header (Closed)

Patch Set: Change "constexpr static" to "static constexpr" for consistency Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 6edeb839da5ced492618dee7455af0594b2be0c0..52cc36806f321ba2d7bc74f7efc3138eb1e023c4 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1622,7 +1622,7 @@ class Smi: public Object {

V8_EXPORT_PRIVATE void SmiPrint(std::ostream& os) const; // NOLINT

DECLARE_VERIFIER(Smi)

- V8_EXPORT_PRIVATE static Smi* const kZero;

+ static constexpr Smi* const kZero = nullptr;

static const int kMinValue =

(static_cast<unsigned int>(-1)) << (kSmiValueSize - 1);

static const int kMaxValue = -(kMinValue + 1);

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »