Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2541513007: Language settings: change spellcheck row; minor code cleanup (Closed)

Created:
4 years ago by michaelpg
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Language settings: change spellcheck row; minor code cleanup Spellcheck row should only be two-line when it actually has secondary text. Also remove unused code, change IDs like-this to likeThis. BUG=none R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/44d9dc8755ee62e35eeb9f4e7c4a7fdc98ef9a43 Cr-Commit-Position: refs/heads/master@{#437139}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.js View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
michaelpg
PTAL; this addresses your comment from https://codereview.chromium.org/2523403003/diff/40001/chrome/browser/resources/settings/languages_page/languages_page.js#newcode403 and tests that behavior, and fixes some spelling ...
4 years ago (2016-12-02 03:37:16 UTC) #2
stevenjb
Thanks, definitely more straightforward. LGTM.
4 years ago (2016-12-02 17:13:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541513007/20001
4 years ago (2016-12-08 00:05:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 02:05:34 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-08 02:08:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44d9dc8755ee62e35eeb9f4e7c4a7fdc98ef9a43
Cr-Commit-Position: refs/heads/master@{#437139}

Powered by Google App Engine
This is Rietveld 408576698