Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2541513007: Language settings: change spellcheck row; minor code cleanup (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 176135ddee39abc4eb272e7c70b04725232763f5..88378886d607ac92e15cf0c42cacfe2dae1f1aec 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -35,9 +35,10 @@ Polymer({
languageHelper: Object,
/** @private */
- spellCheckSecondary_: {
+ spellCheckSecondaryText_: {
type: String,
- value: 'Placeholder, e.g. English (United States)',
+ value: '',
+ computed: 'getSpellCheckSecondaryText_(languages.enabled.*)',
},
/**
@@ -376,6 +377,14 @@ Polymer({
},
/**
+ * @return {string}
+ * @private
+ */
+ getSpellCheckListTwoLine_: function() {
+ return this.spellCheckSecondaryText_.length ? 'two-line' : '';
+ },
+
+ /**
* Returns either the "selected" class, if the language matches the
* prospective UI language, or an empty string. Languages can only be
* selected on Chrome OS and Windows.

Powered by Google App Engine
This is Rietveld 408576698