Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2541513007: Language settings: change spellcheck row; minor code cleanup (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/cr.html"> 3 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 icon="cr:more-vert" on-tap="onDotsTap_"> 125 icon="cr:more-vert" on-tap="onDotsTap_">
126 </paper-icon-button> 126 </paper-icon-button>
127 </div> 127 </div>
128 </template> 128 </template>
129 <div class="list-item list-button" on-tap="onAddLanguagesTap_"> 129 <div class="list-item list-button" on-tap="onAddLanguagesTap_">
130 <a is="action-link">$i18n{addLanguages}</a> 130 <a is="action-link">$i18n{addLanguages}</a>
131 </div> 131 </div>
132 </div> 132 </div>
133 </iron-collapse> 133 </iron-collapse>
134 <if expr="chromeos"> 134 <if expr="chromeos">
135 <div id="manage-input-methods-subpage-trigger" 135 <div id="manageInputMethodsSubpageTrigger"
136 class="settings-box two-line" actionable 136 class="settings-box two-line" actionable
137 on-tap="toggleExpandButton_"> 137 on-tap="toggleExpandButton_">
138 <div class="start"> 138 <div class="start">
139 <div>$i18n{inputMethodsListTitle}</div> 139 <div>$i18n{inputMethodsListTitle}</div>
140 <div class="secondary"> 140 <div class="secondary">
141 [[getInputMethodName_(languages.inputMethods.currentId)]] 141 [[getInputMethodName_(languages.inputMethods.currentId)]]
142 </div> 142 </div>
143 </div> 143 </div>
144 <cr-expand-button expanded="{{inputMethodsOpened_}}" 144 <cr-expand-button expanded="{{inputMethodsOpened_}}"
145 alt="$i18n{inputMethodsExpandA11yLabel}"> 145 alt="$i18n{inputMethodsExpandA11yLabel}">
(...skipping 23 matching lines...) Expand all
169 </div> 169 </div>
170 </template> 170 </template>
171 <div class="list-item list-button" 171 <div class="list-item list-button"
172 on-tap="onManageInputMethodsTap_"> 172 on-tap="onManageInputMethodsTap_">
173 <a is="action-link">$i18n{manageInputMethods}</a> 173 <a is="action-link">$i18n{manageInputMethods}</a>
174 </div> 174 </div>
175 </div> 175 </div>
176 </iron-collapse> 176 </iron-collapse>
177 </if> 177 </if>
178 <if expr="not is_macosx"> 178 <if expr="not is_macosx">
179 <div id="spellcheck-subpage-trigger" class="settings-box two-line" 179 <div id="spellCheckSubpageTrigger"
180 class$="settings-box [[getSpellCheckListTwoLine_(
181 spellCheckSecondaryText_)]]"
180 actionable on-tap="toggleExpandButton_"> 182 actionable on-tap="toggleExpandButton_">
181 <div class="start"> 183 <div class="start">
182 <div>$i18n{spellCheckListTitle}</div> 184 <div>$i18n{spellCheckListTitle}</div>
183 <div class="secondary"> 185 <div class="secondary">[[spellCheckSecondaryText_]]</div>
184 [[getSpellCheckSecondaryText_(languages.enabled.*)]]
185 </div>
186 </div> 186 </div>
187 <cr-expand-button expanded="{{spellCheckOpened_}}" 187 <cr-expand-button expanded="{{spellCheckOpened_}}"
188 alt="$i18n{spellCheckExpandA11yLabel}"> 188 alt="$i18n{spellCheckExpandA11yLabel}">
189 </cr-expand-button> 189 </cr-expand-button>
190 </div> 190 </div>
191 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]"> 191 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
192 <div class="list-frame vertical-list"> 192 <div class="list-frame vertical-list">
193 <template is="dom-repeat" items="[[languages.enabled]]"> 193 <template is="dom-repeat" items="[[languages.enabled]]">
194 <div class="list-item"> 194 <div class="list-item">
195 <paper-checkbox 195 <paper-checkbox
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 on-tap="onRemoveLanguageTap_" 251 on-tap="onRemoveLanguageTap_"
252 hidden="[[!detailLanguage_.removable]]"> 252 hidden="[[!detailLanguage_.removable]]">
253 $i18n{removeLanguage} 253 $i18n{removeLanguage}
254 </button> 254 </button>
255 </dialog> 255 </dialog>
256 </template> 256 </template>
257 </neon-animatable> 257 </neon-animatable>
258 <if expr="chromeos"> 258 <if expr="chromeos">
259 <template is="dom-if" route-path="/inputMethods"> 259 <template is="dom-if" route-path="/inputMethods">
260 <settings-subpage 260 <settings-subpage
261 associated-control="[[$$('#manage-input-methods-subpage-trigger')]]" 261 associated-control="[[$$('#manageInputMethodsSubpageTrigger')]]"
262 page-title="$i18n{manageInputMethodsPageTitle}"> 262 page-title="$i18n{manageInputMethodsPageTitle}">
263 <settings-manage-input-methods-page languages="{{languages}}" 263 <settings-manage-input-methods-page languages="{{languages}}"
264 language-helper="[[languageHelper]]"> 264 language-helper="[[languageHelper]]">
265 </settings-manage-input-methods-page> 265 </settings-manage-input-methods-page>
266 </settings-subpage> 266 </settings-subpage>
267 </template> 267 </template>
268 </if> 268 </if>
269 <if expr="not is_macosx"> 269 <if expr="not is_macosx">
270 <template is="dom-if" route-path="/editDictionary"> 270 <template is="dom-if" route-path="/editDictionary">
271 <settings-subpage 271 <settings-subpage
272 associated-control="[[$$('#spellcheck-subpage-trigger')]]" 272 associated-control="[[$$('#spellCheckSubpageTrigger')]]"
273 page-title="$i18n{editDictionaryPageTitle}"> 273 page-title="$i18n{editDictionaryPageTitle}">
274 <settings-edit-dictionary-page></settings-edit-dictionary-page> 274 <settings-edit-dictionary-page></settings-edit-dictionary-page>
275 </settings-subpage> 275 </settings-subpage>
276 </template> 276 </template>
277 </if> 277 </if>
278 </settings-animated-pages> 278 </settings-animated-pages>
279 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 279 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
280 <settings-add-languages-dialog languages="{{languages}}" 280 <settings-add-languages-dialog languages="{{languages}}"
281 language-helper="[[languageHelper]]"> 281 language-helper="[[languageHelper]]">
282 </settings-add-languages-dialog> 282 </settings-add-languages-dialog>
283 </template> 283 </template>
284 </template> 284 </template>
285 <script src="languages_page.js"></script> 285 <script src="languages_page.js"></script>
286 </dom-module> 286 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698