Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Issue 2541293002: Fix under-invalidation of multicol with rule (Closed)
Patch Set: Fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/multicol-resize-with-rule-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
index 389dbf5879e343401e9a210e4f3cd0d2a38aa162..c4b483124e4a67f3843172c4577e92e6c2ef5d60 100644
--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
@@ -162,6 +162,10 @@ PaintInvalidationReason BoxPaintInvalidator::computePaintInvalidationReason() {
if (m_box.isFrameSet())
return PaintInvalidationBorderBoxChange;
+ // Needs to repaint column rules.
+ if (m_box.isLayoutMultiColumnSet())
+ return PaintInvalidationBorderBoxChange;
+
return PaintInvalidationIncremental;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/multicol-resize-with-rule-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698