Chromium Code Reviews Chromium Code Reviews
Issue
2541123005:
Revert of [NTP] Do not force offline version when opening non-download snippets. (Closed)
DescriptionRevert of [NTP] Do not force offline version when opening non-download snippets. (patchset #1 id:1 of https://codereview.chromium.org/2546583004/ )
Reason for revert:
Broke the official 56 build: https://bugs.chromium.org/p/chromium/issues/detail?id=670559
Seems like https://codereview.chromium.org/2514343003 has to be merged before (doesn't seem to be in the 56 branch according to https://chromium.googlesource.com/chromium/src/+/56.0.2924.14/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java)
Original issue's description:
> [NTP] Do not force offline version when opening non-download snippets.
>
> Previously we always opened an offline page, if there was one. This CL
> simply opens the URL for non-download snippets and then Offline Pages
> decide whether to open its offline page. For Downloads nothing changed.
>
> BUG=668485
>
> Review-Url: https://codereview.chromium.org/2525323003
> Cr-Commit-Position: refs/heads/master@{#434445}
> (cherry picked from commit 6f538029f3659bf667470deca0b22abdcd7cafbd)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c9a10dcad458b7a05ca295a25ae621c30f264f05
TBR=treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668485
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
|||||||||||||||||||
