Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2525323003: [NTP] Do not force offline version when opening non-download snippets. (Closed)

Created:
4 years ago by vitaliii
Modified:
4 years ago
Reviewers:
dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Do not force offline version when opening non-download snippets. Previously we always opened an offline page, if there was one. This CL simply opens the URL for non-download snippets and then Offline Pages decide whether to open its offline page. For Downloads nothing changed. BUG=668485 Committed: https://crrev.com/6f538029f3659bf667470deca0b22abdcd7cafbd Cr-Commit-Position: refs/heads/master@{#434445}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +8 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
vitaliii
Hi dgn@, Would you mind having a look?
4 years ago (2016-11-24 13:33:38 UTC) #2
dgn
lgtm https://codereview.chromium.org/2525323003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2525323003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java#newcode385 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:385: if (article.isDownload() && !article.mIsAssetDownload) { nit: the mIsAssetDownload ...
4 years ago (2016-11-24 15:49:35 UTC) #3
vitaliii
I ack'ed your nit. No need to look. https://codereview.chromium.org/2525323003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (right): https://codereview.chromium.org/2525323003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java#newcode385 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:385: if ...
4 years ago (2016-11-25 06:32:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525323003/1
4 years ago (2016-11-25 06:51:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 07:23:17 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-25 07:24:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f538029f3659bf667470deca0b22abdcd7cafbd
Cr-Commit-Position: refs/heads/master@{#434445}

Powered by Google App Engine
This is Rietveld 408576698