Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2514343003: [NTP] Cleanup: specific category related data and bridge. (Closed)

Created:
4 years, 1 month ago by vitaliii
Modified:
4 years, 1 month ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Cleanup: specific category related data and bridge. This CL: - replaces |(.*)ForLastSuggestion| functions with |\1ForSuggestions|; - renames specific category related data variables to be more consistent with C++ side; - removes mFile variable; BUG=None Committed: https://crrev.com/1f023ad2891968962b0d6ff95a5c33ae919c2d1b Cr-Commit-Position: refs/heads/master@{#433811}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase & mvanouerwerk@ nits. #

Messages

Total messages: 21 (13 generated)
vitaliii
Hi Marc, could you have a look at the bridge related bit?
4 years, 1 month ago (2016-11-21 12:55:41 UTC) #4
Marc Treib
LGTM, nice cleanup!
4 years, 1 month ago (2016-11-21 14:01:52 UTC) #7
vitaliii
Hi Michael, would you mind looking at the java bit of my cleanup?
4 years, 1 month ago (2016-11-21 14:06:58 UTC) #9
Michael van Ouwerkerk
lgtm with nits https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java (right): https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java#newcode144 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:144: * @return the asset download path. ...
4 years, 1 month ago (2016-11-21 16:08:32 UTC) #10
vitaliii
Fixed nits. No need to look. https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java (right): https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java#newcode144 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:144: * @return the ...
4 years, 1 month ago (2016-11-22 06:49:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514343003/20001
4 years, 1 month ago (2016-11-22 07:49:44 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 07:55:47 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 07:58:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f023ad2891968962b0d6ff95a5c33ae919c2d1b
Cr-Commit-Position: refs/heads/master@{#433811}

Powered by Google App Engine
This is Rietveld 408576698