[NTP] Cleanup: specific category related data and bridge.

[NTP] Cleanup: specific category related data and bridge.

This CL:
- replaces |(.*)ForLastSuggestion| functions with |\1ForSuggestions|;
- renames specific category related data variables to be more consistent
  with C++ side;
- removes mFile variable;

BUG=None

Committed: https://crrev.com/1f023ad2891968962b0d6ff95a5c33ae919c2d1b
Cr-Commit-Position: refs/heads/master@{#433811}

[vitaliii, 2016-11-21 12:51:05]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 12:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-11-21 12:55:41]

vitaliii@chromium.org changed reviewers:
+ treib@chromium.org

[vitaliii, 2016-11-21 12:55:41]

Hi Marc,

could you have a look at the bridge related bit?

[commit-bot: I haz the power, 2016-11-21 13:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 13:38:04]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-21 14:01:52]

LGTM, nice cleanup!

[vitaliii, 2016-11-21 14:06:58]

vitaliii@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[vitaliii, 2016-11-21 14:06:58]

Hi Michael,

would you mind looking at the java bit of my cleanup?

[Michael van Ouwerkerk, 2016-11-21 16:08:32]

lgtm with nits

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
(right):

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:144:
* @return the asset download path. May only be called if mIsAssetDownload is
{@code true} and
If you use {@link mIsAssetDownload} then IDEs can link it and rename it when
refactoring.

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:153:
* @return the mime type of the asset download. May only be called if
mIsAssetDownload is
Also @link

[vitaliii, 2016-11-22 06:49:42]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 06:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-11-22 06:49:59]

Fixed nits. No need to look.

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
(right):

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:144:
* @return the asset download path. May only be called if mIsAssetDownload is
{@code true} and
On 2016/11/21 16:08:32, Michael van Ouwerkerk wrote:
> If you use {@link mIsAssetDownload} then IDEs can link it and rename it when
> refactoring.

Done.

https://codereview.chromium.org/2514343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java:153:
* @return the mime type of the asset download. May only be called if
mIsAssetDownload is
On 2016/11/21 16:08:32, Michael van Ouwerkerk wrote:
> Also @link

Done.

[vitaliii, 2016-11-22 07:49:25]

The CQ bit was unchecked by vitaliii@chromium.org

[vitaliii, 2016-11-22 07:49:31]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2016-11-22 07:49:32]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2514343003/#ps20001
(title: "rebase & mvanouerwerk@ nits.")

[commit-bot: I haz the power, 2016-11-22 07:49:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 07:55:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479800971915650,
"parent_rev": "d822c18d7c606d01c39fe3de1340ad67c41448cb", "commit_rev":
"733f59a73f681fa36e28b4c429b26fe5094d54f9"}

[commit-bot: I haz the power, 2016-11-22 07:55:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 07:58:41]

Description was changed from

==========
[NTP] Cleanup: specific category related data and bridge.

This CL:
- replaces |(.*)ForLastSuggestion| functions with |\1ForSuggestions|;
- renames specific category related data variables to be more consistent
  with C++ side;
- removes mFile variable;

BUG=None
==========

to

==========
[NTP] Cleanup: specific category related data and bridge.

This CL:
- replaces |(.*)ForLastSuggestion| functions with |\1ForSuggestions|;
- renames specific category related data variables to be more consistent
  with C++ side;
- removes mFile variable;

BUG=None

Committed: https://crrev.com/1f023ad2891968962b0d6ff95a5c33ae919c2d1b
Cr-Commit-Position: refs/heads/master@{#433811}
==========

[commit-bot: I haz the power, 2016-11-22 07:58:42]

Patchset 2 (id:??) landed as
https://crrev.com/1f023ad2891968962b0d6ff95a5c33ae919c2d1b
Cr-Commit-Position: refs/heads/master@{#433811}