Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2541003004: Fix missing warning for canceling touchmove when in default not passive mode. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix missing warning for canceling touchmove when in default not passive mode. It appears that the the log error was dropped when the default mode enum was added in change https://codereview.chromium.org/2475443004. Add a test to ensure that it doesn't get dropped again. BUG=667799 Review-Url: https://codereview.chromium.org/2536563003 Cr-Commit-Position: refs/heads/master@{#434998} (cherry picked from commit be1e266d539e2caeff5e7b174dba20e88d60f319) Committed: https://chromium.googlesource.com/chromium/src/+/028ca146a4af5f6bcb765b34e14a47bbb1911da8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -67 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html View 1 chunk +71 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable-expected.txt View 1 chunk +11 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years ago (2016-11-30 22:22:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
028ca146a4af5f6bcb765b34e14a47bbb1911da8.

Powered by Google App Engine
This is Rietveld 408576698