Add use counter when touch-action isn't used when preventDefault'd.

Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org

Committed: https://crrev.com/e913a6698f089e11e89fcc04ee19d34dac82d30a
Cr-Commit-Position: refs/heads/master@{#431618}

[dtapuska, 2016-11-02 17:43:26]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[dtapuska, 2016-11-02 17:43:27]

rbyers@ wdyt?

[Rick Byers, 2016-11-07 17:01:09]

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:87: NotPassiveDefault,
nit: add comments making the difference between these values precise

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEvent.h (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEvent.h:118: TouchAction
m_currentTouchAction;
Define this precisely in a comment.  Is it the touch action that was computed
when the first finger went down?  Maybe comment that this is for
analytics/logging only - should never impact the behavior?

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:349:
m_currentTouchAction = effectiveTouchAction;
This isn't sufficient for multi-finger gestures.  IIRC the browser computes the
intersection of the touch actions for each active finger.  If I'm not forgetting
some subtlty then I think you can trivially repeat that logic here (ignoring
OOPIF anyway).

[dtapuska, 2016-11-07 18:51:29]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2016-11-07 18:51:40]

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:87: NotPassiveDefault,
On 2016/11/07 17:01:09, Rick Byers wrote:
> nit: add comments making the difference between these values precise

Done.

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEvent.h (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEvent.h:118: TouchAction
m_currentTouchAction;
On 2016/11/07 17:01:09, Rick Byers wrote:
> Define this precisely in a comment.  Is it the touch action that was computed
> when the first finger went down?  Maybe comment that this is for
> analytics/logging only - should never impact the behavior?

Done.

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/2475443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:349:
m_currentTouchAction = effectiveTouchAction;
On 2016/11/07 17:01:09, Rick Byers wrote:
> This isn't sufficient for multi-finger gestures.  IIRC the browser computes
the
> intersection of the touch actions for each active finger.  If I'm not
forgetting
> some subtlty then I think you can trivially repeat that logic here (ignoring
> OOPIF anyway).

Done.

[commit-bot: I haz the power, 2016-11-07 18:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 20:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 20:05:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Rick Byers, 2016-11-10 16:39:32]

LGTM

[dtapuska, 2016-11-11 16:24:32]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 16:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:26:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dtapuska, 2016-11-11 16:28:04]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-11-11 16:32:18]

Description was changed from

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
==========

to

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org
==========

[dtapuska, 2016-11-11 16:32:38]

dtapuska@chromium.org changed reviewers:
+ isherman@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:36:49]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dtapuska, 2016-11-11 16:41:37]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:41:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 16:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:47:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2016-11-11 17:01:57]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 17:02:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 19:29:16]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2016-11-11 19:29:41]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-11 19:29:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2475443004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-11 19:30:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:45:28]

Description was changed from

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org
==========

to

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org
==========

[commit-bot: I haz the power, 2016-11-11 19:45:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-11 20:00:06]

Description was changed from

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org
==========

to

==========
Add use counter when touch-action isn't used when preventDefault'd.

Keep track of the lack of usage of touch-action on pages.

BUG=639227
TBR=isherman@chromium.org

Committed: https://crrev.com/e913a6698f089e11e89fcc04ee19d34dac82d30a
Cr-Commit-Position: refs/heads/master@{#431618}
==========

[commit-bot: I haz the power, 2016-11-11 20:00:07]

Patchset 6 (id:??) landed as
https://crrev.com/e913a6698f089e11e89fcc04ee19d34dac82d30a
Cr-Commit-Position: refs/heads/master@{#431618}

[Ilya Sherman, 2016-11-11 21:31:39]

histograms.xml lgtm