Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2536563003: Fix missing warning for canceling touchmove when in default not passive mode. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing warning for canceling touchmove when in default not passive mode. It appears that the the log error was dropped when the default mode enum was added in change https://codereview.chromium.org/2475443004. Add a test to ensure that it doesn't get dropped again. BUG=667799 Committed: https://crrev.com/be1e266d539e2caeff5e7b174dba20e88d60f319 Cr-Commit-Position: refs/heads/master@{#434998}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -67 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html View 1 1 chunk +71 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable-expected.txt View 1 2 1 chunk +11 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
dtapuska
PTAL; this fixes the missing warning
4 years ago (2016-11-28 15:30:29 UTC) #5
Rick Byers
LGTM with nit https://codereview.chromium.org/2536563003/diff/1/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html File third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html (right): https://codereview.chromium.org/2536563003/diff/1/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html#newcode65 third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html:65: console.log('Sending cancelable touchmove'); nit: fix log ...
4 years ago (2016-11-28 18:42:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536563003/20001
4 years ago (2016-11-28 23:37:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/339828)
4 years ago (2016-11-29 00:59:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536563003/40001
4 years ago (2016-11-29 14:10:27 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-29 15:49:06 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-29 15:52:06 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be1e266d539e2caeff5e7b174dba20e88d60f319
Cr-Commit-Position: refs/heads/master@{#434998}

Powered by Google App Engine
This is Rietveld 408576698