[inspector] fixed Debugger.getPossibleBreakpoints

[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call PrepareFunctionForBreakPoints and won't be able to step into this function or pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/891e31241c9558a9b1537fa48c5b2211d275837f
Cr-Commit-Position: refs/heads/master@{#41401}

[kozy, 2016-11-30 03:16:58]

Description was changed from

==========
[inspector] fixed Debugger.getPossibleBreakpoints

BUG=none
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=none
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2016-11-30 03:17:47]

Yang, please take a look.
Without patch in added test frame inside of function boo is missed.

[kozy, 2016-11-30 04:30:41]

Description was changed from

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=none
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org
==========

[Yang, 2016-11-30 20:44:37]

https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc#newcode1363
src/debug/debug.cc:1363: if (!EnsureDebugInfo(candidates[i],
Handle<JSFunction>::null()))
I think you can remove the whole if block checking for HasDebugCode.

[kozy, 2016-11-30 22:21:59]

https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc#newcode1363
src/debug/debug.cc:1363: if (!EnsureDebugInfo(candidates[i],
Handle<JSFunction>::null()))
On 2016/11/30 20:44:36, Yang wrote:
> I think you can remove the whole if block checking for HasDebugCode.

I can remove this block if I'll pass JSFunction as second arguments of
EnsureDebugInfo, otherwise DCHECK(shared->HasDebugCode()); will fails inside of
EnsureDebugInfo. Can I get any of JSFunction object from shared function info?
And I think that it's possible that current shared function info doesn't have
any corresponded JSFunction object.

[Yang, 2016-11-30 23:37:27]

On 2016/11/30 22:21:59, kozyatinskiy wrote:
> https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc
> File src/debug/debug.cc (right):
> 
>
https://codereview.chromium.org/2540943002/diff/1/src/debug/debug.cc#newcode1363
> src/debug/debug.cc:1363: if (!EnsureDebugInfo(candidates[i],
> Handle<JSFunction>::null()))
> On 2016/11/30 20:44:36, Yang wrote:
> > I think you can remove the whole if block checking for HasDebugCode.
> 
> I can remove this block if I'll pass JSFunction as second arguments of
> EnsureDebugInfo, otherwise DCHECK(shared->HasDebugCode()); will fails inside
of
> EnsureDebugInfo. Can I get any of JSFunction object from shared function info?
> And I think that it's possible that current shared function info doesn't have
> any corresponded JSFunction object.

ah i see. lgtm

[kozy, 2016-11-30 23:52:02]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:26:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480549922533570, "parent_rev":
"a2ccaffee4b19f3271b63dc978217a424f83bf4e", "commit_rev":
"db495727c6383d171a96472364a08a8808762a80"}

[commit-bot: I haz the power, 2016-12-01 00:26:07]

Description was changed from

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-12-01 00:26:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 00:26:47]

Description was changed from

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] fixed Debugger.getPossibleBreakpoints

If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call
PrepareFunctionForBreakPoints and won't be able to step into this function or
pause at breakpoint inside.

BUG=v8:5695
R=dgozman@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/891e31241c9558a9b1537fa48c5b2211d275837f
Cr-Commit-Position: refs/heads/master@{#41401}
==========

[commit-bot: I haz the power, 2016-12-01 00:26:48]

Patchset 1 (id:??) landed as
https://crrev.com/891e31241c9558a9b1537fa48c5b2211d275837f
Cr-Commit-Position: refs/heads/master@{#41401}