Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/debug/debug.cc

Issue 2540943002: [inspector] fixed Debugger.getPossibleBreakpoints (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/inspector/debugger/get-possible-breakpoints-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index c0420a273fbf030439dc4471a3daa66091026e8a..919f968658e3c2bba07de3b49018dead33106e3a 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -1360,7 +1360,8 @@ bool Debug::GetPossibleBreakpoints(Handle<Script> script, int start_position,
was_compiled = true;
}
}
- if (!candidates[i]->HasDebugInfo()) CreateDebugInfo(candidates[i]);
+ if (!EnsureDebugInfo(candidates[i], Handle<JSFunction>::null()))
Yang 2016/11/30 20:44:36 I think you can remove the whole if block checking
kozy 2016/11/30 22:21:58 I can remove this block if I'll pass JSFunction as
+ return false;
}
if (was_compiled) continue;
« no previous file with comments | « no previous file | test/inspector/debugger/get-possible-breakpoints-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698