[inspector] fixed Debugger.getPossibleBreakpoints

src/debug/debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug.h"
 
 #include <memory>
 
 #include "src/api.h"
 #include "src/arguments.h"
@@ skipping 1342 matching lines @@
     for (int i = 0; i < candidates.length(); ++i) {
       // Code that cannot be compiled lazily are internal and not debuggable.
       DCHECK(candidates[i]->allows_lazy_compilation());
       if (!candidates[i]->HasDebugCode()) {
         if (!Compiler::CompileDebugCode(candidates[i])) {
           return false;
         } else {
           was_compiled = true;
         }
       }
-      if (!candidates[i]->HasDebugInfo()) CreateDebugInfo(candidates[i]);
+      if (!EnsureDebugInfo(candidates[i], Handle<JSFunction>::null()))

[Yang, 2016/11/30 20:44:36]

I think you can remove the whole if block checking for HasDebugCode.

[kozy, 2016/11/30 22:21:58]

I can remove this block if I'll pass JSFunction as second arguments of
EnsureDebugInfo, otherwise DCHECK(shared->HasDebugCode()); will fails inside of
EnsureDebugInfo. Can I get any of JSFunction object from shared function info?
And I think that it's possible that current shared function info doesn't have
any corresponded JSFunction object.

+        return false;
     }
     if (was_compiled) continue;
 
     for (int i = 0; i < candidates.length(); ++i) {
       CHECK(candidates[i]->HasDebugInfo());
       Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo());
       FindBreakablePositions(debug_info, start_position, end_position,
                              STATEMENT_ALIGNED, positions);
     }
     return true;
@@ skipping 751 matching lines @@
 v8::Debug::ClientData* EventDetailsImpl::GetClientData() const {
   return client_data_;
 }
 
 v8::Isolate* EventDetailsImpl::GetIsolate() const {
   return reinterpret_cast<v8::Isolate*>(exec_state_->GetIsolate());
 }
 
 }  // namespace internal
 }  // namespace v8