Add the concept of QueueEnabledVoters to blink scheduler TaskQueue

Add the concept of QueueEnabledVoters to blink scheduler TaskQueue

More than one system wants to be able to enable and disable task queues.
The TaskQueue::QueueEnabledVoter lets them safely vote on which queues
are enabled and disabled.

BUG=

Committed: https://crrev.com/cb9a395877572dc7d8ffbf154f728223f9044282
Cr-Commit-Position: refs/heads/master@{#435031}

[alex clarke (OOO till 29th), 2016-11-29 12:18:33]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-11-29 12:29:26]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 12:29:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 13:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 13:56:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-11-29 14:45:17]

+tzik@ FYI

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
(right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:122:
std::unique_ptr<QueueEnabledVoter> GetQueueEnabledVoter() override;
s/Get/Create/ to make this a bit more obvious.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:304: void
QueueEnabledVoteChanged(bool enabled);
nit: OnQueueEnabledVoteChanged?

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1150:
}
If we don't have a voter:

  DCHECK(new_task_queue_policy.is_enabled);

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:122: class
QueueEnabledVoter {
I think "voter" works but just to throw another (somewhat stl-inspired) idea out
there: SharedEnableState

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:135: virtual
TaskQueue* GetTaskQueue() const = 0;
GetTaskQueueForTest? Doesn't seem like we need this for anything else.
(Alternatively we could cast to the Impl class in the test and get the queue
from there)

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:143: // or of all
agree it should be enabled.
s/of/if/

[alex clarke (OOO till 29th), 2016-11-29 16:49:01]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-11-29 16:49:11]

PTAL

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
(right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:122:
std::unique_ptr<QueueEnabledVoter> GetQueueEnabledVoter() override;
On 2016/11/29 14:45:17, Sami wrote:
> s/Get/Create/ to make this a bit more obvious.

Done.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:304: void
QueueEnabledVoteChanged(bool enabled);
On 2016/11/29 14:45:16, Sami wrote:
> nit: OnQueueEnabledVoteChanged?

Done.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1150:
}
On 2016/11/29 14:45:17, Sami wrote:
> If we don't have a voter:
> 
>   DCHECK(new_task_queue_policy.is_enabled);

Done.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:122: class
QueueEnabledVoter {
On 2016/11/29 14:45:17, Sami wrote:
> I think "voter" works but just to throw another (somewhat stl-inspired) idea
out
> there: SharedEnableState

Acknowledged.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:135: virtual
TaskQueue* GetTaskQueue() const = 0;
On 2016/11/29 14:45:17, Sami wrote:
> GetTaskQueueForTest? Doesn't seem like we need this for anything else.
> (Alternatively we could cast to the Impl class in the test and get the queue
> from there)

Done.

https://codereview.chromium.org/2540663002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:143: // or of all
agree it should be enabled.
On 2016/11/29 14:45:17, Sami wrote:
> s/of/if/

Done.

[commit-bot: I haz the power, 2016-11-29 16:49:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-11-29 18:02:02]

Thanks, lgtm!

[alex clarke (OOO till 29th), 2016-11-29 18:02:21]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-11-29 18:02:25]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2016-11-29 18:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 18:08:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480442545880310,
"parent_rev": "9f311e2e8b3e58c5cbc5244731165b5a1be7bc4a", "commit_rev":
"b4897f35f55076aebf8711265eb125c09f238771"}

[commit-bot: I haz the power, 2016-11-29 18:08:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 18:12:21]

Description was changed from

==========
Add the concept of QueueEnabledVoters to blink scheduler TaskQueue

More than one system wants to be able to enable and disable task queues.
The TaskQueue::QueueEnabledVoter lets them safely vote on which queues
are enabled and disabled.

BUG=
==========

to

==========
Add the concept of QueueEnabledVoters to blink scheduler TaskQueue

More than one system wants to be able to enable and disable task queues.
The TaskQueue::QueueEnabledVoter lets them safely vote on which queues
are enabled and disabled.

BUG=

Committed: https://crrev.com/cb9a395877572dc7d8ffbf154f728223f9044282
Cr-Commit-Position: refs/heads/master@{#435031}
==========

[commit-bot: I haz the power, 2016-11-29 18:12:22]

Patchset 3 (id:??) landed as
https://crrev.com/cb9a395877572dc7d8ffbf154f728223f9044282
Cr-Commit-Position: refs/heads/master@{#435031}