third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc - Issue 2540663002: Add the concept of QueueEnabledVoters to blink scheduler TaskQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc

Issue 2540663002: Add the concept of QueueEnabledVoters to blink scheduler TaskQueue (Closed)

Patch Set: Fix test crashes and address feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc b/third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc

index 5a1c188a3e5bb50cd2ab07b4d7ba4a09ad2e11cf..e0935523d170340b5279f2e31a4e2b4443398b96 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc

+++ b/third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc

@@ -66,7 +66,7 @@ void IdleHelper::Shutdown() {

is_shutdown_ = true;

weak_factory_.InvalidateWeakPtrs();

// Belt & braces, might not be needed.

- idle_queue_->SetQueueEnabled(false);

+ idle_queue_->InsertFence(TaskQueue::InsertFencePosition::BEGINNING_OF_TIME);

helper_->RemoveTaskObserver(this);

}