Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h

Issue 2540663002: Add the concept of QueueEnabledVoters to blink scheduler TaskQueue (Closed)
Patch Set: Fix test crashes and address feedback. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
index a9cf6adfa0e08d84effddacf47e5d1f94e2ba073..ba9e59709303f4f5d79e6684ecbf97c3636cf352 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
@@ -360,9 +360,11 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
// Report an intervention to all WebViews in this process.
void BroadcastIntervention(const std::string& message);
- void ApplyTaskQueuePolicy(TaskQueue* task_queue,
- const TaskQueuePolicy& old_task_queue_policy,
- const TaskQueuePolicy& new_task_queue_policy) const;
+ void ApplyTaskQueuePolicy(
+ TaskQueue* task_queue,
+ TaskQueue::QueueEnabledVoter* task_queue_enabled_voter,
+ const TaskQueuePolicy& old_task_queue_policy,
+ const TaskQueuePolicy& new_task_queue_policy) const;
static const char* ExpensiveTaskPolicyToString(
ExpensiveTaskPolicy expensive_task_policy);
@@ -376,8 +378,15 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
const scoped_refptr<TaskQueue> control_task_runner_;
const scoped_refptr<TaskQueue> compositor_task_runner_;
- std::set<scoped_refptr<TaskQueue>> loading_task_runners_;
- std::set<scoped_refptr<TaskQueue>> timer_task_runners_;
+ std::unique_ptr<TaskQueue::QueueEnabledVoter>
+ compositor_task_runner_enabled_voter_;
+
+ using TaskQueueVoterMap =
+ std::map<scoped_refptr<TaskQueue>,
+ std::unique_ptr<TaskQueue::QueueEnabledVoter>>;
+
+ TaskQueueVoterMap loading_task_runners_;
+ TaskQueueVoterMap timer_task_runners_;
std::set<scoped_refptr<TaskQueue>> unthrottled_task_runners_;
scoped_refptr<TaskQueue> default_loading_task_runner_;
scoped_refptr<TaskQueue> default_timer_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698