[Download Home] Adjust space display again

[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/view?usp=sharing

BUG=658246
Committed: https://crrev.com/5bf713ed8ab6407c18b7cbd3c39e68c7c2908c0a
Cr-Commit-Position: refs/heads/master@{#434833}

[gone, 2016-11-29 00:24:22]

Description was changed from

==========
[Download Home] Adjust space display.  Again.

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246
==========

to

==========
[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246
==========

[gone, 2016-11-29 00:25:09]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2016-11-29 00:37:13]

lgtm

https://codereview.chromium.org/2540583002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/download_manager_ui_space_widget.xml
(right):

https://codereview.chromium.org/2540583002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/download_manager_ui_space_widget.xml:12: -->
While this is certainly useful for reviewing the CL, I'm not sure the verbosity
is necessary when looking back at the code later. Maybe it should read:

<!-- Widget style adapted from the UX spec in crbug.com/658246 -->

[gone, 2016-11-29 00:48:20]

https://codereview.chromium.org/2540583002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/download_manager_ui_space_widget.xml
(right):

https://codereview.chromium.org/2540583002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/download_manager_ui_space_widget.xml:12: -->
On 2016/11/29 00:37:13, Theresa Wellington wrote:
> While this is certainly useful for reviewing the CL, I'm not sure the
verbosity
> is necessary when looking back at the code later. Maybe it should read:
> 
> <!-- Widget style adapted from the UX spec in crbug.com/658246 -->

Was trying to refer to the comments following specific comment with the images;
went halfway and kept the link directly pointing at the images UX provided.

[gone, 2016-11-29 00:48:50]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-11-29 00:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2540583002/#ps20001
(title: "[Download Home] Adjust space display.  Again.")

[commit-bot: I haz the power, 2016-11-29 00:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:14:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480380530371450,
"parent_rev": "2aad13f86d517d82b32bad56d50353517933e23d", "commit_rev":
"3fd2a71e7d9e98fe9cc0b545a55e168b5af0af0c"}

[commit-bot: I haz the power, 2016-11-29 02:14:48]

Description was changed from

==========
[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246
==========

to

==========
[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246
==========

[commit-bot: I haz the power, 2016-11-29 02:14:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 02:20:34]

Description was changed from

==========
[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246
==========

to

==========
[Download Home] Adjust space display again

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/v...
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/v...

BUG=658246

Committed: https://crrev.com/5bf713ed8ab6407c18b7cbd3c39e68c7c2908c0a
Cr-Commit-Position: refs/heads/master@{#434833}
==========

[commit-bot: I haz the power, 2016-11-29 02:20:35]

Patchset 2 (id:??) landed as
https://crrev.com/5bf713ed8ab6407c18b7cbd3c39e68c7c2908c0a
Cr-Commit-Position: refs/heads/master@{#434833}