Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: chrome/android/java/res/layout/download_manager_ui_space_widget.xml

Issue 2540583002: [Download Home] Adjust space display again (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <merge xmlns:android="http://schemas.android.com/apk/res/android"> 6 <merge xmlns:android="http://schemas.android.com/apk/res/android">
7 7
8 <!-- Values in this file are a best effort attempt to match the dimensions i n the "spec", which
9 had to be heavily interpreted for implementation.
10
11 https://bugs.chromium.org/p/chromium/issues/detail?id=658246&desc=2#c18
12 -->
Theresa 2016/11/29 00:37:13 While this is certainly useful for reviewing the C
gone 2016/11/29 00:48:20 Was trying to refer to the comments following spec
8 <LinearLayout 13 <LinearLayout
9 android:layout_width="match_parent" 14 android:layout_width="match_parent"
10 android:layout_height="wrap_content" 15 android:layout_height="wrap_content"
11 android:layout_marginStart="@dimen/drawer_margin_large" 16 android:layout_marginStart="@dimen/drawer_margin_large"
12 android:layout_marginEnd="@dimen/drawer_margin_large" 17 android:layout_marginEnd="@dimen/drawer_margin_large"
18 android:paddingTop="26dp"
19 android:paddingBottom="24dp"
13 android:orientation="vertical" > 20 android:orientation="vertical" >
14 21
15 <TextView 22 <TextView
16 android:id="@+id/size_downloaded" 23 android:id="@+id/size_downloaded"
17 android:layout_width="match_parent" 24 android:layout_width="match_parent"
18 android:layout_height="wrap_content" 25 android:layout_height="wrap_content"
19 android:singleLine="true" 26 android:singleLine="true"
20 android:textColor="@color/light_active_color" 27 android:textColor="@color/light_active_color"
21 android:textSize="20sp" /> 28 android:textSize="20sp" />
22 29
23 <!-- The widget ends up claiming 32dp of space, vertically. --> 30 <!-- The progress bar uses 32dp of space, vertically, including spacing. -->
24 <ProgressBar 31 <ProgressBar
25 android:id="@+id/space_bar" 32 android:id="@+id/space_bar"
26 style="@style/MaterialProgressBar" 33 style="@style/MaterialProgressBar"
27 android:layout_width="match_parent" 34 android:layout_width="match_parent"
28 android:layout_height="4dp" 35 android:layout_height="4dp"
29 android:layout_marginTop="14dp" 36 android:layout_marginTop="14dp"
30 android:layout_marginBottom="14dp" /> 37 android:layout_marginBottom="14dp" />
31 38
32 <TextView 39 <TextView
33 android:id="@+id/size_other_apps" 40 android:id="@+id/size_other_apps"
34 android:layout_width="match_parent" 41 android:layout_width="match_parent"
35 android:layout_height="wrap_content" 42 android:layout_height="wrap_content"
36 android:singleLine="true" 43 android:singleLine="true"
37 android:textColor="@color/google_grey_600" 44 android:textColor="@color/google_grey_600"
38 android:textSize="14sp" /> 45 android:textSize="12sp" />
39 46
40 <TextView 47 <TextView
41 android:id="@+id/size_free" 48 android:id="@+id/size_free"
42 android:layout_width="match_parent" 49 android:layout_width="match_parent"
43 android:layout_height="wrap_content" 50 android:layout_height="wrap_content"
44 android:layout_marginBottom="22dp"
45 android:singleLine="true" 51 android:singleLine="true"
46 android:textColor="@color/material_progressbar_bg" 52 android:textColor="@color/google_grey_400"
47 android:textSize="14sp" /> 53 android:textSize="12sp" />
48 54
49 </LinearLayout> 55 </LinearLayout>
50 56
51 </merge> 57 </merge>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/download_main.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698