Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/android/java/res/layout/download_manager_ui_space_widget.xml

Issue 2540583002: [Download Home] Adjust space display again (Closed)
Patch Set: [Download Home] Adjust space display. Again. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/download_main.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/download_manager_ui_space_widget.xml
diff --git a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
index 2840692b5094ee4e7b2261221028897fe5e677b1..ba99847b042eef5c973e9d8e1f0d5e4651620198 100644
--- a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
+++ b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
@@ -5,11 +5,16 @@
<merge xmlns:android="http://schemas.android.com/apk/res/android">
+ <!-- Widget style adapted from the UX spec:
+ https://bugs.chromium.org/p/chromium/issues/detail?id=658246&desc=2#c18
+ -->
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/drawer_margin_large"
android:layout_marginEnd="@dimen/drawer_margin_large"
+ android:paddingTop="26dp"
+ android:paddingBottom="24dp"
android:orientation="vertical" >
<TextView
@@ -20,7 +25,7 @@
android:textColor="@color/light_active_color"
android:textSize="20sp" />
- <!-- The widget ends up claiming 32dp of space, vertically. -->
+ <!-- The progress bar uses 32dp of space, vertically, including spacing. -->
<ProgressBar
android:id="@+id/space_bar"
style="@style/MaterialProgressBar"
@@ -35,16 +40,15 @@
android:layout_height="wrap_content"
android:singleLine="true"
android:textColor="@color/google_grey_600"
- android:textSize="14sp" />
+ android:textSize="12sp" />
<TextView
android:id="@+id/size_free"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_marginBottom="22dp"
android:singleLine="true"
- android:textColor="@color/material_progressbar_bg"
- android:textSize="14sp" />
+ android:textColor="@color/google_grey_400"
+ android:textSize="12sp" />
</LinearLayout>
« no previous file with comments | « chrome/android/java/res/layout/download_main.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698