Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp - Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

index 42392c7189f66e6996c7f44778fe8d919151d128..9375e68320511a757db76a400f338c137c69f5cf 100644

--- a/Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

@@ -47,7 +47,7 @@ namespace WebCore {

v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)

{

HandleScope handleScope;

- HTMLFrameSetElement* imp = V8HTMLFrameSetElement::toNative(info.Holder());

+ Handle<HTMLFrameSetElement> imp = adoptRawResult(V8HTMLFrameSetElement::toNative(info.Holder()));

Handle<Node> frameNode = imp->children()->namedItem(toWebCoreAtomicString(name));

if (!frameNode)

return v8Undefined();

@@ -58,7 +58,7 @@ v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::S

return v8Undefined();

if (!document->frame())

return v8Undefined();

- return toV8Fast(document->domWindow(), info, imp);

+ return toV8Fast(document->domWindow(), info, imp.raw());

}

} // namespace WebCore