Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp - Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLFormElementCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

index 10164ec885c8635a3fedeca5b94d0da3cd9b89f7..18af1e9ff1ed4bf8b29bf6c40b09508b219f83f7 100644

--- a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

@@ -42,7 +42,7 @@ using namespace HTMLNames;

void V8HTMLFrameElement::locationAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)

{

- HTMLFrameElement* frame = V8HTMLFrameElement::toNative(info.Holder());

+ Handle<HTMLFrameElement> frame = adoptRawResult(V8HTMLFrameElement::toNative(info.Holder()));

String locationValue = toWebCoreStringWithNullCheck(value);

if (!BindingSecurity::allowSettingFrameSrcToJavascriptUrl(BindingState::instance(), frame, locationValue))