Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp
index 9dfc4f1dbf03986b2213cedef7d3abd5c2e0b3e5..1255486d0eab733b2a2a4535db6f33d30d6e09bf 100644
--- a/Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp
+++ b/Source/bindings/v8/custom/V8HTMLInputElementCustom.cpp
@@ -40,7 +40,7 @@ namespace WebCore {
v8::Handle<v8::Value> V8HTMLInputElement::selectionStartAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection())
return throwTypeError("Accessing selectionStart on an input element that cannot have a selection.", info.GetIsolate());
@@ -52,7 +52,7 @@ v8::Handle<v8::Value> V8HTMLInputElement::selectionStartAttrGetterCustom(v8::Loc
void V8HTMLInputElement::selectionStartAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection()) {
throwTypeError("Accessing selectionStart on an input element that cannot have a selection.", info.GetIsolate());
@@ -64,7 +64,7 @@ void V8HTMLInputElement::selectionStartAttrSetterCustom(v8::Local<v8::String> na
v8::Handle<v8::Value> V8HTMLInputElement::selectionEndAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection())
return throwTypeError("Accessing selectionEnd on an input element that cannot have a selection.", info.GetIsolate());
@@ -76,7 +76,7 @@ v8::Handle<v8::Value> V8HTMLInputElement::selectionEndAttrGetterCustom(v8::Local
void V8HTMLInputElement::selectionEndAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection()) {
throwTypeError("Accessing selectionEnd on an input element that cannot have a selection.", info.GetIsolate());
@@ -89,7 +89,7 @@ void V8HTMLInputElement::selectionEndAttrSetterCustom(v8::Local<v8::String> name
v8::Handle<v8::Value> V8HTMLInputElement::selectionDirectionAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection())
return throwTypeError("Accessing selectionDirection on an input element that cannot have a selection.", info.GetIsolate());
@@ -100,7 +100,7 @@ v8::Handle<v8::Value> V8HTMLInputElement::selectionDirectionAttrGetterCustom(v8:
void V8HTMLInputElement::selectionDirectionAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
v8::Handle<v8::Object> holder = info.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection()) {
throwTypeError("Accessing selectionDirection on an input element that cannot have a selection.", info.GetIsolate());
@@ -113,7 +113,7 @@ void V8HTMLInputElement::selectionDirectionAttrSetterCustom(v8::Local<v8::String
v8::Handle<v8::Value> V8HTMLInputElement::setSelectionRangeMethodCustom(const v8::Arguments& args)
{
v8::Handle<v8::Object> holder = args.Holder();
- HTMLInputElement* imp = V8HTMLInputElement::toNative(holder);
+ Handle<HTMLInputElement> imp = adoptRawResult(V8HTMLInputElement::toNative(holder));
if (!imp->canHaveSelection())
return throwTypeError("Calling setSelectionRange on an input element that cannot have a selection.", args.GetIsolate());

Powered by Google App Engine
This is Rietveld 408576698