Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2512093003: Stub out Skia AVX and HSW opts. (Closed)

Created:
4 years, 1 month ago by mtklein_C
Modified:
4 years, 1 month ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stub out Skia AVX and HSW opts. This is hopefully temporary while we mull better options. BUG=666707 Committed: https://crrev.com/2ea76e2274404af7e53cc4bb5d212b22856ee455 Cr-Commit-Position: refs/heads/master@{#433407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M skia/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
A skia/ext/SkOpts_avx_stub.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A skia/ext/SkOpts_hsw_stub.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
mtklein_C
4 years, 1 month ago (2016-11-18 21:59:09 UTC) #2
Nico
On 2016/11/18 21:59:09, mtklein_C wrote: Lgtm Maybe we can make the bug public?
4 years, 1 month ago (2016-11-18 22:05:34 UTC) #5
mtklein_C
On 2016/11/18 at 22:05:34, thakis wrote: > On 2016/11/18 21:59:09, mtklein_C wrote: > > Lgtm ...
4 years, 1 month ago (2016-11-18 22:09:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512093003/1
4 years, 1 month ago (2016-11-18 22:13:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/167444)
4 years, 1 month ago (2016-11-18 22:20:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512093003/1
4 years, 1 month ago (2016-11-18 23:56:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/318377)
4 years, 1 month ago (2016-11-19 02:25:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512093003/1
4 years, 1 month ago (2016-11-19 06:10:34 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 07:09:37 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2ea76e2274404af7e53cc4bb5d212b22856ee455 Cr-Commit-Position: refs/heads/master@{#433407}
4 years, 1 month ago (2016-11-19 07:11:32 UTC) #20
mtklein_C
4 years ago (2016-11-29 13:27:12 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2539453003/ by mtklein@chromium.org.

The reason for reverting is: Now that we're guarding against ucrt\math.h in Skia
and that's rolled into Chromium, it's as good a time as ever to try turning back
on Skia's AVX+ code at head.  (I intend to just leave it stubbed out like this
in M56.).

Powered by Google App Engine
This is Rietveld 408576698