Replace base::File wrapping with typemapping.

Replace base::File wrapping with typemapping.

BUG=668384
Committed: https://crrev.com/c21489788171f2087b55cca7844508a43c123384
Cr-Commit-Position: refs/heads/master@{#436814}

[Sam McNally, 2016-12-01 07:27:32]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 07:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:50:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-12-01 08:46:03]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 08:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-01 08:59:28]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-12-01 09:08:27]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:08:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-01 09:09:12]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-01 09:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 09:36:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sam McNally, 2016-12-05 00:19:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 00:19:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-05 00:19:21]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-12-05 00:19:23]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-12-05 00:37:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-12-05 00:37:35]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-12-05 00:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 01:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 01:22:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-12-05 01:27:25]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 01:27:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 03:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 03:06:19]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-05 03:08:30]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-12-05 03:08:44]

Description was changed from

==========
Replace base::File wrapping with base::File typemapping.

BUG=668384
==========

to

==========
Replace base::File wrapping with typemapping.

BUG=668384
==========

[Sam McNally, 2016-12-05 03:37:26]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, eae@chromium.org, erg@chromium.org, rockot@chromium.org

[Sam McNally, 2016-12-05 03:37:26]

+rockot for //services/catalog

+eae for blink and //content/browser/hyphenation

+erg for //components

+dcheng for the mojoms

[eae, 2016-12-05 13:43:44]

LGTM for for blink and //content/browser/hyphenation

[dcheng, 2016-12-05 19:33:04]

LGTM

(One other bikeshed: maybe common_custom_types should be renamed to reflect that
it's really just a placeholder for typemapped //base things)

https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
File components/filesystem/directory_impl.cc (right):

https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
components/filesystem/directory_impl.cc:342: return
base::File(static_cast<base::File::Error>(error));
This is a little ugly. Maybe we can/should just typemap this so it Just Works in
the future?

[Ken Rockot(use gerrit already), 2016-12-05 20:00:36]

LGTM 

On 2016/12/05 at 19:33:04, dcheng wrote:
> LGTM
> 
> (One other bikeshed: maybe common_custom_types should be renamed to reflect
that it's really just a placeholder for typemapped //base things)

I agree 100% with this - "common custom types" seems like a poor name, but let's
save it for another CL.

> 
>
https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
> File components/filesystem/directory_impl.cc (right):
> 
>
https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
> components/filesystem/directory_impl.cc:342: return
base::File(static_cast<base::File::Error>(error));
> This is a little ugly. Maybe we can/should just typemap this so it Just Works
in the future?

[Elliot Glaysher, 2016-12-06 18:47:06]

//components lgtm

[Sam McNally, 2016-12-06 23:15:18]

https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
File components/filesystem/directory_impl.cc (right):

https://codereview.chromium.org/2539383002/diff/120001/components/filesystem/...
components/filesystem/directory_impl.cc:342: return
base::File(static_cast<base::File::Error>(error));
On 2016/12/05 19:33:04, dcheng wrote:
> This is a little ugly. Maybe we can/should just typemap this so it Just Works
in
> the future?

Acknowledged.

[Sam McNally, 2016-12-06 23:15:25]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:14:10]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481066125853040,
"parent_rev": "888c83278c21308c60dbe2bf64bac23e2ab13c72", "commit_rev":
"6df1ddc2704ab3fee44b690c5672e04eecb21cba"}

[commit-bot: I haz the power, 2016-12-07 01:14:34]

Description was changed from

==========
Replace base::File wrapping with typemapping.

BUG=668384
==========

to

==========
Replace base::File wrapping with typemapping.

BUG=668384
==========

[commit-bot: I haz the power, 2016-12-07 01:14:36]

Committed patchset #1 (id:120001)

[commit-bot: I haz the power, 2016-12-07 01:18:54]

Description was changed from

==========
Replace base::File wrapping with typemapping.

BUG=668384
==========

to

==========
Replace base::File wrapping with typemapping.

BUG=668384

Committed: https://crrev.com/c21489788171f2087b55cca7844508a43c123384
Cr-Commit-Position: refs/heads/master@{#436814}
==========

[commit-bot: I haz the power, 2016-12-07 01:18:55]

Patchset 1 (id:??) landed as
https://crrev.com/c21489788171f2087b55cca7844508a43c123384
Cr-Commit-Position: refs/heads/master@{#436814}