Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: components/filesystem/file_impl_unittest.cc

Issue 2539383002: Replace base::File wrapping with typemapping. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/filesystem/file_impl_unittest.cc
diff --git a/components/filesystem/file_impl_unittest.cc b/components/filesystem/file_impl_unittest.cc
index 81544b488c46972ebd9868ce2769773e7c7c1270..be20bfbe9c7cc00f755fcb826a36912e0fb0ff3a 100644
--- a/components/filesystem/file_impl_unittest.cc
+++ b/components/filesystem/file_impl_unittest.cc
@@ -11,7 +11,6 @@
#include "components/filesystem/files_test_base.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/type_converter.h"
-#include "mojo/public/cpp/system/platform_handle.h"
namespace filesystem {
namespace {
@@ -663,21 +662,13 @@ TEST_F(FileImplTest, AsHandle) {
ASSERT_TRUE(handled);
EXPECT_EQ(mojom::FileError::OK, error);
- // Fetch the handle
+ // Fetch the file.
error = mojom::FileError::FAILED;
- mojo::ScopedHandle handle;
- handled = file1->AsHandle(&error, &handle);
+ base::File raw_file;
+ handled = file1->AsHandle(&error, &raw_file);
ASSERT_TRUE(handled);
EXPECT_EQ(mojom::FileError::OK, error);
- // Pull a file descriptor out of the scoped handle.
- base::PlatformFile platform_file;
- MojoResult unwrap_result = mojo::UnwrapPlatformFile(std::move(handle),
- &platform_file);
- EXPECT_EQ(MOJO_RESULT_OK, unwrap_result);
-
- // Pass this raw file descriptor to a base::File.
- base::File raw_file(platform_file);
ASSERT_TRUE(raw_file.IsValid());
EXPECT_EQ(5, raw_file.WriteAtCurrentPos("hello", 5));
}

Powered by Google App Engine
This is Rietveld 408576698