Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 2555853003: Break up common_custom_types.mojom. (Closed)

Created:
4 years ago by Sam McNally
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, asvitkine+watch_chromium.org, awdf+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, browser-components-watch_chromium.org, cc-bugs_chromium.org, chasej+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, cmumford, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, elijahtaylor+arcwatch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, hidehiko+watch_chromium.org, horo+watch_chromium.org, iclelland+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, jkarlin+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, kinuko+serviceworker, kinuko+watch, lhchavez+watch_chromium.org, mathp+autofillwatch_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, michaeln, miu+watch_chromium.org, mlamouri+watch-notifications_chromium.org, nhiroki, Peter Beverloo, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, tdresser+watch_chromium.org, tfarina, tzik, vabr+watchlistautofill_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break up common_custom_types.mojom. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/041c065f9642c035a27a057a4a6e9950913db027 Cr-Commit-Position: refs/heads/master@{#437122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -151 lines) Patch
M cc/ipc/begin_frame_args.mojom View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/local_frame_id.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/profile_import.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/common/bluetooth.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/common/autofill_agent.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/common/autofill_driver.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/common/autofill_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/file.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/public/interfaces/font_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/public/interfaces/leveldb.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/public/interfaces/call_stack_profile_collector.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M components/startup_metric_utils/common/startup_metric.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/common/translate.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db.mojom View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_event_dispatcher.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/video_capture.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/ipc/common/gpu_info.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M media/capture/mojo/video_capture_types.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/renderer.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
D mojo/common/common_custom_types.mojom View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/common/common_custom_types.typemap View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/common/common_custom_types_struct_traits.h View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A mojo/common/file.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
A mojo/common/file.typemap View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/common/file_path.mojom View 1 chunk +8 lines, -0 lines 0 comments Download
A mojo/common/file_path.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/common/string16.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/common/string16.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/common/test_common_custom_types.mojom View 1 chunk +6 lines, -1 line 0 comments Download
A mojo/common/time.mojom View 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/common/time.typemap View 1 chunk +20 lines, -0 lines 0 comments Download
M mojo/common/traits_test_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/typemaps.gni View 1 chunk +9 lines, -1 line 0 comments Download
A mojo/common/unguessable_token.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
A mojo/common/unguessable_token.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/common/values.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
A mojo/common/values.typemap View 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/common/version.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
A mojo/common/version.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
M services/catalog/public/interfaces/catalog.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/pref_observer_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/preferences/public/cpp/pref_observer_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/interfaces/resolver.mojom View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/mojo/CommonCustomTypes.typemap View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mojo/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/mojo/File.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/mojo/String.typemap View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mojo/blink_typemaps.gni View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/hyphenation/hyphenation.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/mediasession/media_session.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/latency_info.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/mojo/notification.mojom View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
Sam McNally
+noel for //third_party/WebKit/Source/platform +rockot for //mojo, //services and //extensions +dcheng for mojoms and struct traits
4 years ago (2016-12-07 07:30:42 UTC) #12
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-07 17:06:26 UTC) #13
dcheng
lgtm
4 years ago (2016-12-07 18:35:13 UTC) #14
Noel Gordon
lgtm
4 years ago (2016-12-07 23:39:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555853003/1
4 years ago (2016-12-07 23:58:10 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 01:43:32 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-08 01:47:18 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/041c065f9642c035a27a057a4a6e9950913db027
Cr-Commit-Position: refs/heads/master@{#437122}

Powered by Google App Engine
This is Rietveld 408576698