Fix for constructor search.

Fix for constructor search.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a0fa2083d355d76b5e314b6534c7f73a8ee77902

[Brian Wilkerson, 2016-11-30 21:46:10]

lgtm

[scheglov, 2016-11-30 22:00:02]

Description was changed from

==========
Fix for constructor search.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fix for constructor search.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a0fa2083d355d76b5e314b6534c7f73a8ee77902
==========

[scheglov, 2016-11-30 22:00:03]

Committed patchset #1 (id:1) manually as
a0fa2083d355d76b5e314b6534c7f73a8ee77902 (presubmit successful).

[Paul Berry, 2016-12-01 13:18:03]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2016-12-01 13:18:04]

https://codereview.chromium.org/2539263002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2539263002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:162: String other =
_p('$testProject/other.dart');
This test fails on Windows.  See
https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/bu...

  AnalysisException: Cannot compute DART_ERRORS for C:\test\lib/other.dart
  Caused by Element mismatch in C:\test\lib\other.dart at C:\test\lib\other.dart
  #0      DeclarationResolver.resolve
(package:analyzer/src/generated/declaration_resolver.dart:50:7)
  #1      BuildCompilationUnitElementTask.internalPerform
(package:analyzer/src/task/dart.dart:1082:33)

Can you have a look?

[scheglov, 2016-12-01 16:38:41]

On 2016/12/01 13:18:04, Paul Berry wrote:
>
https://codereview.chromium.org/2539263002/diff/1/pkg/analyzer/test/src/dart/...
> File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):
> 
>
https://codereview.chromium.org/2539263002/diff/1/pkg/analyzer/test/src/dart/...
> pkg/analyzer/test/src/dart/analysis/search_test.dart:162: String other =
> _p('$testProject/other.dart');
> This test fails on Windows.  See
>
https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/bu...
> 
>   AnalysisException: Cannot compute DART_ERRORS for C:\test\lib/other.dart
>   Caused by Element mismatch in C:\test\lib\other.dart at
C:\test\lib\other.dart
>   #0      DeclarationResolver.resolve
> (package:analyzer/src/generated/declaration_resolver.dart:50:7)
>   #1      BuildCompilationUnitElementTask.internalPerform
> (package:analyzer/src/task/dart.dart:1082:33)
> 
> Can you have a look?

https://codereview.chromium.org/2542793003 will fix the failure.