Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2542793003: Make MemoryResourceProvider.convertPath() work with partially posix paths. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make MemoryResourceProvider.convertPath() work with partially posix paths. So that 'C:\some\path/to/file.dart' -> 'C:\some\path\to\file.dart'. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/aaaeee5bc4891da203c39272f371feb946f1cd00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years ago (2016-12-01 16:38:06 UTC) #1
Paul Berry
lgtm
4 years ago (2016-12-01 16:39:14 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as aaaeee5bc4891da203c39272f371feb946f1cd00 (presubmit successful).
4 years ago (2016-12-01 16:39:50 UTC) #4
Brian Wilkerson
4 years ago (2016-12-01 17:10:35 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698