Fix for constructor search.

pkg/analyzer/test/src/dart/analysis/search_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/dart/analysis/search.dart';
@@ skipping 123 matching lines @@
 ''');
     CompilationUnitElement element = _findElementAtString('my_part');
     var expected = [
       _expectIdQ(element.library.definingCompilationUnit,
           SearchResultKind.REFERENCE, "'my_part.dart'",
           length: "'my_part.dart'".length)
     ];
     await _verifyReferences(element, expected);
   }
 
-  test_searchReferences_ConstructorElement() async {
+  test_searchReferences_ConstructorElement_default() async {
+    await _resolveTestUnit('''
+class A {
+  A() {}
+}
+main() {
+  new A();
+}
+''');
+    ConstructorElement element = _findElementAtString('A() {}');
+    Element mainElement = _findElement('main');
+    var expected = [
+      _expectIdQ(mainElement, SearchResultKind.REFERENCE, '();', length: 0)
+    ];
+    await _verifyReferences(element, expected);
+  }
+
+  test_searchReferences_ConstructorElement_default_otherFile() async {
+    String other = _p('$testProject/other.dart');

[Paul Berry, 2016/12/01 13:18:03]

This test fails on Windows.  See
https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/bu...

  AnalysisException: Cannot compute DART_ERRORS for C:\test\lib/other.dart
  Caused by Element mismatch in C:\test\lib\other.dart at C:\test\lib\other.dart
  #0      DeclarationResolver.resolve
(package:analyzer/src/generated/declaration_resolver.dart:50:7)
  #1      BuildCompilationUnitElementTask.internalPerform
(package:analyzer/src/task/dart.dart:1082:33)

Can you have a look?

+    String otherCode = '''
+import 'test.dart';
+main() {
+  new A(); // in other
+}
+''';
+    provider.newFile(other, otherCode);
+    driver.addFile(other);
+
+    await _resolveTestUnit('''
+class A {
+  A() {}
+}
+''');
+    ConstructorElement element = _findElementAtString('A() {}');
+
+    CompilationUnit otherUnit = (await driver.getResult(other)).unit;
+    Element main = otherUnit.element.functions[0];
+    var expected = [
+      new ExpectedResult(main, SearchResultKind.REFERENCE,
+          otherCode.indexOf('(); // in other'), 0,
+          isResolved: true, isQualified: true)
+    ];
+    await _verifyReferences(element, expected);
+  }
+
+  test_searchReferences_ConstructorElement_named() async {
     await _resolveTestUnit('''
 class A {
   A.named() {}
 }
 main() {
   new A.named();
 }
 ''');
     ConstructorElement element = _findElement('named');
     Element mainElement = _findElement('main');
     var expected = [
       _expectIdQ(mainElement, SearchResultKind.REFERENCE, '.named();',
-          length: 6)
+          length: '.named'.length)
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_ConstructorElement_synthetic() async {
     await _resolveTestUnit('''
 class A {
 }
 main() {
   new A();
@@ skipping 638 matching lines @@
     List<SearchResult> results = await driver.search.references(element);
     _assertResults(results, expectedMatches);
     expect(results, hasLength(expectedMatches.length));
   }
 
   static void _assertResults(
       List<SearchResult> matches, List<ExpectedResult> expectedMatches) {
     expect(matches, unorderedEquals(expectedMatches));
   }
 }