[Findit] Report the error from the last flake swarming task that failed in master_flake_analysis.py

[Findit] Report the error from the last flake swarming task that failed in master_flake_analysis.py

BUG=669182
Committed: https://chromium.googlesource.com/infra/infra/+/cd4c1197b2c8c677500d63d1a564c4bb08188d18

[lijeffrey, 2016-11-28 21:06:47]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-11-28 21:06:48]

This change should have been part of https://codereview.chromium.org/2491473002/
and forgot to update recursive_flake_pipeline.py also to pick up the error that
was detected from process_base_swarming_task_result_pipeline.py.

With this change the flake analyses pages should also report the same error
detected in process_base_swarming_task_pipeline.py instead of the generic
"Swarming task failed" message.

PTAL when you have the chance.

Thanks,
Jeff

[chanli, 2016-11-28 22:27:54]

https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
(right):

https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:869: def
testUpdateAnalysisUponCompletionError(self):
This test case is not what I expect for your new change? Shouldn't you have a
test case where you have a failed flake_swarming_task and use the error message
from the task?

[lijeffrey, 2016-11-28 23:37:09]

https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
(right):

https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:869: def
testUpdateAnalysisUponCompletionError(self):
On 2016/11/28 22:27:54, chanli wrote:
> This test case is not what I expect for your new change? Shouldn't you have a
> test case where you have a failed flake_swarming_task and use the error
message
> from the task?

Done.

[chanli, 2016-11-28 23:49:36]

On 2016/11/28 23:37:09, lijeffrey wrote:
>
https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
> File appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
> (right):
> 
>
https://codereview.chromium.org/2538533002/diff/1/appengine/findit/waterfall/...
> appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:869:
def
> testUpdateAnalysisUponCompletionError(self):
> On 2016/11/28 22:27:54, chanli wrote:
> > This test case is not what I expect for your new change? Shouldn't you have
a
> > test case where you have a failed flake_swarming_task and use the error
> message
> > from the task?
> 
> Done.

lgtm

[lijeffrey, 2016-11-28 23:57:27]

The CQ bit was checked by lijeffrey@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:57:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:14:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480377447019200,
"parent_rev": "5857c3d1328ba9795d222825e882c6ed0d2be36a", "commit_rev":
"cd4c1197b2c8c677500d63d1a564c4bb08188d18"}

[commit-bot: I haz the power, 2016-11-29 00:14:19]

Description was changed from

==========
[Findit] Report the error from the last flake swarming task that failed in
master_flake_analysis.py

BUG=669182
==========

to

==========
[Findit] Report the error from the last flake swarming task that failed in
master_flake_analysis.py

BUG=669182

Committed:
https://chromium.googlesource.com/infra/infra/+/cd4c1197b2c8c677500d63d1a564c...
==========

[commit-bot: I haz the power, 2016-11-29 00:14:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/cd4c1197b2c8c677500d63d1a564c...