[Findit] Report the error from the last flake swarming task that failed in master_flake_analysis.py

appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import mock
 
 from common import constants
 from common.pipeline_wrapper import pipeline_handlers
 from model import analysis_status
@@ skipping 848 matching lines @@
         master_name, builder_name, master_build_number, step_name, test_name)
     self.assertEqual(analysis_status.COMPLETED, analysis.status)
 
   def testUpdateAnalysisUponCompletionFound(self):
     analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
     analysis.suspected_flake_build_number = 100
     recursive_flake_pipeline._UpdateAnalysisStatusUponCompletion(
         analysis, analysis_status.COMPLETED, None)
     self.assertEqual(analysis.result_status, result_status.FOUND_UNTRIAGED)
 
+  def testUpdateAnalysisUponCompletionError(self):

[chanli, 2016/11/28 22:27:54]

This test case is not what I expect for your new change? Shouldn't you have a
test case where you have a failed flake_swarming_task and use the error message
from the task?

[lijeffrey, 2016/11/28 23:37:09]

Done.

+    expected_error = {
+        'code': 1,
+        'message': 'some error message'
+    }
+    analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+    analysis.suspected_flake_build_number = 100
+    recursive_flake_pipeline._UpdateAnalysisStatusUponCompletion(
+        analysis, analysis_status.COMPLETED, expected_error)
+    self.assertEqual(expected_error, analysis.error)
+
   def testGetListOfNearbyBuildNumbers(self):
     self.assertEqual(
         [1],
         recursive_flake_pipeline._GetListOfNearbyBuildNumbers(1, 0))
     self.assertEqual(
         [1],
         recursive_flake_pipeline._GetListOfNearbyBuildNumbers(1, -1))
     self.assertEqual(
         [1, 2],
         recursive_flake_pipeline._GetListOfNearbyBuildNumbers(1, 1))
@@ skipping 230 matching lines @@
     calls = mocked_pipeline.mock_calls
     self.assertEqual(2, len(calls))
 
     _, args, __ = calls[0]
     bug_id, comment, labels = args
     self.assertEqual(123, bug_id)
     self.assertEqual(['AnalyzedByFindit'], labels)
     self.assertTrue('om / ob / os' in comment)
 
     self.assertEqual(mock.call().start(queue_name='queue'), calls[1])