Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2519)

Unified Diff: appengine/findit/waterfall/flake/recursive_flake_pipeline.py

Issue 2538533002: [Findit] Report the error from the last flake swarming task that failed in master_flake_analysis.py (Closed)
Patch Set: Addressing comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/flake/recursive_flake_pipeline.py
diff --git a/appengine/findit/waterfall/flake/recursive_flake_pipeline.py b/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
index f66ad5972cf90fc2d7b14ce646e6a0d511fae0f8..0541ed0399e33cd23a88a2210347777331e373fd 100644
--- a/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
+++ b/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
@@ -402,14 +402,14 @@ class NextBuildNumberPipeline(BasePipeline):
# Don't call another pipeline if we fail.
if flake_swarming_task.status == analysis_status.ERROR:
- # TODO(lijeffrey): Implement more detailed error detection and reporting,
- # such as timeouts, dead bots, etc.
+ # Report the last flake swarming task's error that it encountered.
# TODO(lijeffrey): Another neighboring swarming task may be needed in this
# one's place instead of failing altogether.
- error = {
+ error = flake_swarming_task.error or {
'error': 'Swarming task failed',
- 'message': 'Swarming task failed'
+ 'message': 'The last swarming task did not complete as expected'
}
+
_UpdateAnalysisStatusUponCompletion(
master_flake_analysis, analysis_status.ERROR, error)
return
« no previous file with comments | « no previous file | appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698