chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: filter out browser side navigation browser tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html ('k') | chrome/test/data/safe_browsing/download_protection/navigation_observer/page_before_landing_referrer.html » ('j') | testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

diff --git a/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html b/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

index ba3736564d1d5eef6e55ade917d02170ec6c753c..7f9ce65dd16d401da217789087d7e640eec1bf5d 100644

--- a/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

+++ b/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

@@ -117,6 +117,14 @@

Download via HTML5 file system API

- </a>

+ </a><br>

+ <a id="complete_referer_chain" href="redirect_to_landing.html">

Nathan Parker 2016/12/05 22:21:24 nit: complete_referrer_chain (unless you're trying

Jialiu Lin 2016/12/06 23:10:07 Thanks for catching this. Done.

+ Click on landing referrer and landing page then reach download

+ </a><br>

+ <a id="attribution_within_two_user_gestures" href="page_before_landing_referrer.html">

+ Attribution should not trace back more than 2 user gestures.

+ </a><br>

</body>

</html>