chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: filter out browser side navigation browser tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html ('k') | chrome/test/data/safe_browsing/download_protection/navigation_observer/page_before_landing_referrer.html » ('j') | testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 // Click on a link by id to star a test case.	4 // Click on a link by id to star a test case.

5 function clickLink(linkId) {	5 function clickLink(linkId) {

6 var node = document.getElementById(linkId);	6 var node = document.getElementById(linkId);

7 if (node != null) {	7 if (node != null) {

8 // Click and open link in the same tab.	8 // Click and open link in the same tab.

9 node.click();	9 node.click();

10 }	10 }

(...skipping 99 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
110 <a id="new_tab_download" href="#" onclick="downloadInNewTab(); return false; ">	110 <a id="new_tab_download" href="#" onclick="downloadInNewTab(); return false; ">

111 Open download in new tab	111 Open download in new tab

112 </a><br>	112 </a><br>

113	113

114 <a id="new_tab_download_with_data_url" href="#" onclick="downloadInNewTabWit hDataURL(); return false;">	114 <a id="new_tab_download_with_data_url" href="#" onclick="downloadInNewTabWit hDataURL(); return false;">

115 Open download in new tab with data url	115 Open download in new tab with data url

116 </a><br>	116 </a><br>

117	117

118 <a id="html5_file_api" href="" onclick="downloadViaFileApi()">	118 <a id="html5_file_api" href="" onclick="downloadViaFileApi()">

119 Download via HTML5 file system API	119 Download via HTML5 file system API

120 </a>	120 </a><br>

	121

	122 <a id="complete_referer_chain" href="redirect_to_landing.html">
	Nathan Parker 2016/12/05 22:21:24 nit: complete_referrer_chain (unless you're trying nit: complete_referrer_chain (unless you're trying to match the header name) Jialiu Lin 2016/12/06 23:10:07 Thanks for catching this. Done. Show quoted text On 2016/12/05 22:21:24, Nathan Parker wrote: > nit: complete_referrer_chain (unless you're trying to match the header name) Thanks for catching this. Done.
	123 Click on landing referrer and landing page then reach download

	124 </a><br>

	125

	126 <a id="attribution_within_two_user_gestures" href="page_before_landing_refer rer.html">

	127 Attribution should not trace back more than 2 user gestures.

	128 </a><br>

121 </body>	129 </body>

122 </html>	130 </html>

OLD	NEW