testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: filter out browser side navigation browser tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/redirect_to_landing.html ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

diff --git a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

index 7bf3459a836f87ced85f6b5ccf152a6304de3091..1b5d62a71ad0711365bfff0803d2eb688d14b096 100644

--- a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

+++ b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

@@ -10,6 +10,9 @@

-ThreatDOMDetailsTest.Everything

-WebNavigationApiTest.RequestOpenTab

-WebNavigationApiTest.UserAction

+-SBNavigationObserverBrowserTest.NewTabDownload

Nathan Parker 2016/12/05 22:21:24 Why do these need to be disabled? Should we add a

Jialiu Lin 2016/12/06 23:10:07 As we discussed in person, I'll remove these tests

+-SBNavigationObserverBrowserTest.NewTabDownloadWithDataURL

+-SBNavigationObserverBrowserTest.SubFrameNewTabDownload

# https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes

# returns null for browser-side navigations