testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Side by Side Diff: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: rebase-update Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/test/data/safe_browsing/download_protection/navigation_observer/redirect_to_landing.html ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/redirect_to_landing.html ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled	1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled

2 -PDFExtensionTest.PdfAccessibilityInOOPIF	2 -PDFExtensionTest.PdfAccessibilityInOOPIF

3 -PlatformAppBrowserTest.ActiveAppsAreRecorded	3 -PlatformAppBrowserTest.ActiveAppsAreRecorded

4 -PlatformAppUrlRedirectorBrowserTest.PrerenderedClickInTabIntercepted	4 -PlatformAppUrlRedirectorBrowserTest.PrerenderedClickInTabIntercepted

5 -PredictorBrowserTest.RendererInitiatedNavigationPreconnect	5 -PredictorBrowserTest.RendererInitiatedNavigationPreconnect

6 -PrerenderBrowserTest.PrerenderCrossProcessServerRedirect	6 -PrerenderBrowserTest.PrerenderCrossProcessServerRedirect

7 -PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang	7 -PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang

8 # TabManagerTest.TabManagerBasics crashes sometimes	8 # TabManagerTest.TabManagerBasics crashes sometimes

9 -TabManagerTest.TabManagerBasics	9 -TabManagerTest.TabManagerBasics

10 -ThreatDOMDetailsTest.Everything	10 -ThreatDOMDetailsTest.Everything

	11 -SBNavigationObserverBrowserTest.NewTabDownload

	12 -SBNavigationObserverBrowserTest.NewTabDownloadWithDataURL

	13 -SBNavigationObserverBrowserTest.SubFrameNewTabDownload
	Charlie Reis 2016/12/09 22:00:26 I don't see other SafeBrowsing tests in here. Do I don't see other SafeBrowsing tests in here. Do you know why these need to be disabled? (Changing this filter file requires a PlzNavigate owner. I'm in that owners list, but I know they're looking to avoid adding new tests to the filter.) Jialiu Lin 2016/12/12 23:43:38 This is because the browser_site_navigation_test s Show quoted text On 2016/12/09 22:00:26, Charlie Reis wrote: > I don't see other SafeBrowsing tests in here. Do you know why these need to be > disabled? (Changing this filter file requires a PlzNavigate owner. I'm in that > owners list, but I know they're looking to avoid adding new tests to the > filter.) This is because the browser_site_navigation_test seems to impact the result of NavigationHanle::IsRendererInitiated(). And my code depends on this function to determine if the download is triggered by users (browser_initiated \|\| has_user_gesture). Do you know if this is a known bug or it is WAI in PlzNavigate world? Charlie Reis 2016/12/14 07:43:57 Maybe it has to do with how these tests are settin Show quoted text On 2016/12/12 23:43:38, Jialiu Lin wrote: > On 2016/12/09 22:00:26, Charlie Reis wrote: > > I don't see other SafeBrowsing tests in here. Do you know why these need to > be > > disabled? (Changing this filter file requires a PlzNavigate owner. I'm in > that > > owners list, but I know they're looking to avoid adding new tests to the > > filter.) > > This is because the browser_site_navigation_test seems to impact the result of > NavigationHanle::IsRendererInitiated(). And my code depends on this function to > determine if the download is triggered by users (browser_initiated \|\| > has_user_gesture). Do you know if this is a known bug or it is WAI in > PlzNavigate world? Maybe it has to do with how these tests are setting up their navigation? clamy@, do you know? I know PlzNavigate folks are getting close to a Finch trial, so we should probably figure this out before landing so that we can omit these tests from this filter file. Jialiu Lin 2016/12/14 19:06:29 clamy@'s test patch works. If clamy@'s going to la Show quoted text On 2016/12/14 07:43:57, Charlie Reis wrote: > On 2016/12/12 23:43:38, Jialiu Lin wrote: > > On 2016/12/09 22:00:26, Charlie Reis wrote: > > > I don't see other SafeBrowsing tests in here. Do you know why these need to > > be > > > disabled? (Changing this filter file requires a PlzNavigate owner. I'm in > > that > > > owners list, but I know they're looking to avoid adding new tests to the > > > filter.) > > > > This is because the browser_site_navigation_test seems to impact the result of > > NavigationHanle::IsRendererInitiated(). And my code depends on this function > to > > determine if the download is triggered by users (browser_initiated \|\| > > has_user_gesture). Do you know if this is a known bug or it is WAI in > > PlzNavigate world? > > Maybe it has to do with how these tests are setting up their navigation? > clamy@, do you know? > > I know PlzNavigate folks are getting close to a Finch trial, so we should > probably figure this out before landing so that we can omit these tests from > this filter file. clamy@'s test patch works. If clamy@'s going to land this patch soon, I'll wait for her. Or I can land my CL first and remove these tests from this file later. Charlie Reis 2016/12/15 00:38:33 Great! Sounds like it's a problem on the PlzNavig Show quoted text On 2016/12/14 19:06:29, Jialiu Lin wrote: > On 2016/12/14 07:43:57, Charlie Reis wrote: > > On 2016/12/12 23:43:38, Jialiu Lin wrote: > > > On 2016/12/09 22:00:26, Charlie Reis wrote: > > > > I don't see other SafeBrowsing tests in here. Do you know why these need > to > > > be > > > > disabled? (Changing this filter file requires a PlzNavigate owner. I'm > in > > > that > > > > owners list, but I know they're looking to avoid adding new tests to the > > > > filter.) > > > > > > This is because the browser_site_navigation_test seems to impact the result > of > > > NavigationHanle::IsRendererInitiated(). And my code depends on this function > > to > > > determine if the download is triggered by users (browser_initiated \|\| > > > has_user_gesture). Do you know if this is a known bug or it is WAI in > > > PlzNavigate world? > > > > Maybe it has to do with how these tests are setting up their navigation? > > clamy@, do you know? > > > > I know PlzNavigate folks are getting close to a Finch trial, so we should > > probably figure this out before landing so that we can omit these tests from > > this filter file. > clamy@'s test patch works. If clamy@'s going to land this patch soon, I'll > wait for her. Or I can land my CL first and remove these tests from this file > later. Great! Sounds like it's a problem on the PlzNavigate side rather than your CL, so I think it'll be ok if this lands with these tests disabled for the moment, and clamy@ can fix and re-enable. (Sound ok, clamy@?)
11	14

12 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes	15 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes

13 # returns null for browser-side navigations	16 # returns null for browser-side navigations

14 -PageLoadMetricsBrowserTest.Ignore204Pages	17 -PageLoadMetricsBrowserTest.Ignore204Pages

15 -PageLoadMetricsBrowserTest.IgnoreDownloads	18 -PageLoadMetricsBrowserTest.IgnoreDownloads

16	19

17 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet	20 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet

18 # with PlzNavigate	21 # with PlzNavigate

19 -ResourcePrefetchPredictorBrowserTest.*	22 -ResourcePrefetchPredictorBrowserTest.*

20	23

21 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle	24 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle

22 -NoStatePrefetchBrowserTest.PrefetchLoadFlag	25 -NoStatePrefetchBrowserTest.PrefetchLoadFlag

23 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags	26 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags

OLD	NEW