tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2b4c1893ea6f974961797557c45edde4e7ae75ee..fce2e5ba1d8cd7c789c55f9aaabc760125cb4229 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -53352,6 +53352,34 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SafeBrowsing.ReferrerAttributionResult"
+    units="SafeBrowsingAttributionResultTypes">

[Steven Holte, 2016/12/10 00:33:30]

units -> enum

[Jialiu Lin, 2016/12/12 23:43:38]

Oops, thanks for catching this.

+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    The result of referrer attribution, including different types of success or
+    failure. This is incremented each time when a safe browsing ping or download

[Charlie Reis, 2016/12/09 22:00:26]

nit: Drop "when"

[Jialiu Lin, 2016/12/12 23:43:38]

Done.

+    ping is generated.
+  </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.ReferrerHasInvalidTabID" enum="BooleanInvalid">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    Number of times referrer attribution encounters an invalid tab ID. This is
+    incremented when a safe browsing ping or download ping is generated and an
+    invalid tab ID is encountered during attribution.
+  </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.ReferrerURLChainSize">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    The size of referrer URL chain we get from referrer attribution. This is

[Steven Holte, 2016/12/10 00:33:30]

Size -> length/ number of URLs?  I assumed you meant in bytes until I looked at
code.

[Jialiu Lin, 2016/12/12 23:43:38]

Oh yes, it means length. Thanks for pointing out this ambiguity. 

+    incremented each time when a safe browsing ping or download ping is

[Charlie Reis, 2016/12/09 22:00:26]

nit: Drop "when"

[Jialiu Lin, 2016/12/12 23:43:38]

Done.

+    generated.
+  </summary>
+</histogram>
+
 <histogram name="SafeBrowsing.UnverifiedDownloads.Allowed"
     enum="SBClientDownloadExtensions">
   <owner>asanka@chromium.org</owner>
@@ -100298,6 +100326,14 @@ value.
   <int value="1" label="Kill (He's dead, Jim!)"/>
 </enum>
 
+<enum name="SafeBrowsingAttributionResultTypes" type="int">
+  <int value="1" label="SUCCESS"/>
+  <int value="2" label="SUCCESS_LANDING_PAGE"/>
+  <int value="3" label="SUCCESS_LANDING_REFERRER"/>
+  <int value="4" label="INVALID_URL"/>
+  <int value="5" label="NAVIGATION_EVENT_NOT_FOUND"/>
+</enum>
+
 <enum name="SafeBrowsingParseV4HashResult" type="int">
   <int value="0" label="PARSE_FROM_STRING_ERROR"/>
   <int value="1" label="UNEXPECTED_THREAT_ENTRY_TYPE_ERROR"/>
@@ -112850,6 +112886,19 @@ value.
   <affected-histogram name="Renderer4.ImageDecodeTaskDurationUs"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="ReferrerAttribution" separator=".">
+  <suffix name="DownloadAttribution" label="Download referrer attribution."/>
+  <suffix name="PhishingInterstitialAttribution"
+      label="Phishing interstitial referrer attribution."/>
+  <suffix name="MalwareInterstitialAttribution"
+      label="Malware interstitial referrer attribution."/>
+  <suffix name="UwsInterstitialAttribution"
+      label="UwS interstitial referrer attribution."/>
+  <affected-histogram name="SafeBrowsing.ReferrerAttributionResult"/>
+  <affected-histogram name="SafeBrowsing.ReferrerHasInvalidTabID"/>
+  <affected-histogram name="SafeBrowsing.ReferrerURLChainSize"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="RemoteProcessWarmStartFast" separator="">
   <suffix name="" label="Normal start."/>
   <suffix name="Fast"