Add management related code to SafeBrowsingNavigationObserverManager

testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Index: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
diff --git a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
index 998192dc4f274358cfd3fd3d947c375be92a4005..7c82a4e4b1a1e774f94fd91e790df7a212f07877 100644
--- a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
+++ b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
@@ -8,6 +8,9 @@
 # TabManagerTest.TabManagerBasics crashes sometimes
 -TabManagerTest.TabManagerBasics
 -ThreatDOMDetailsTest.Everything
+-SBNavigationObserverBrowserTest.NewTabDownload
+-SBNavigationObserverBrowserTest.NewTabDownloadWithDataURL
+-SBNavigationObserverBrowserTest.SubFrameNewTabDownload

[Charlie Reis, 2016/12/09 22:00:26]

I don't see other SafeBrowsing tests in here.  Do you know why these need to be
disabled?  (Changing this filter file requires a PlzNavigate owner.  I'm in that
owners list, but I know they're looking to avoid adding new tests to the
filter.)

[Jialiu Lin, 2016/12/12 23:43:38]

This is because the browser_site_navigation_test seems to impact the result of
NavigationHanle::IsRendererInitiated(). And my code depends on this function to
determine if the download is triggered by users (browser_initiated ||
has_user_gesture). Do you know if this is a known bug or it is WAI in
PlzNavigate world?

[Charlie Reis, 2016/12/14 07:43:57]

Maybe it has to do with how these tests are setting up their navigation? 
clamy@, do you know?

I know PlzNavigate folks are getting close to a Finch trial, so we should
probably figure this out before landing so that we can omit these tests from
this filter file.

[Jialiu Lin, 2016/12/14 19:06:29]

clamy@'s test patch works. If clamy@'s going to land this patch soon, I'll
wait for her. Or I can land my CL first and remove these tests from this file
later. 

[Charlie Reis, 2016/12/15 00:38:33]

Great!  Sounds like it's a problem on the PlzNavigate side rather than your CL,
so I think it'll be ok if this lands with these tests disabled for the moment,
and clamy@ can fix and re-enable.  (Sound ok, clamy@?)

 
 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes
 # returns null for browser-side navigations